RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:48:10 +00:00
Code Issues Activity Actions

LanguageServers/Cpp: Avoid some unnecessary vector copies

Browse source
This commit is contained in:
Andreas Kling 2020-10-29 22:25:41 +01:00
parent c3a79e1483
commit aaf4ec62cf
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
DevTools/HackStudio/LanguageServers/Cpp/AutoComplete.cpp
View file

@ -32,7 +32,7 @@
namespace LanguageServers::Cpp {
Vector<AutoCompleteResponse> AutoComplete::get_suggestions(const String& code, GUI::TextPosition autocomplete_position)
Vector<AutoCompleteResponse> AutoComplete::get_suggestions(const String& code, const GUI::TextPosition& autocomplete_position)
{
auto lines = code.split('\n', true);
Lexer lexer(code);
@ -53,12 +53,12 @@ Vector<AutoCompleteResponse> AutoComplete::get_suggestions(const String& code, G
return suggestions;
}
String AutoComplete::text_of_token(const Vector<String> lines, const Cpp::Token& token)
String AutoComplete::text_of_token(const Vector<String>& lines, const Cpp::Token& token)
{
return lines[token.m_start.line].substring(token.m_start.column, token.m_end.column - token.m_start.column + 1);
}
Optional<size_t> AutoComplete::token_in_position(const Vector<Cpp::Token>& tokens, GUI::TextPosition position)
Optional<size_t> AutoComplete::token_in_position(const Vector<Cpp::Token>& tokens, const GUI::TextPosition& position)
{
for (size_t token_index = 0; token_index < tokens.size(); ++token_index) {
auto& token = tokens[token_index];
@ -71,7 +71,7 @@ Optional<size_t> AutoComplete::token_in_position(const Vector<Cpp::Token>& token
return {};
}
Vector<AutoCompleteResponse> AutoComplete::identifier_prefixes(const Vector<String> lines, const Vector<Cpp::Token>& tokens, size_t target_token_index)
Vector<AutoCompleteResponse> AutoComplete::identifier_prefixes(const Vector<String>& lines, const Vector<Cpp::Token>& tokens, size_t target_token_index)
{
auto partial_input = text_of_token(lines, tokens[target_token_index]);
Vector<AutoCompleteResponse> suggestions;