RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:17:35 +00:00
Code Issues Activity Actions

LibJS: Simplify Cell::initialize()

Browse source 
Remove the Interpreter& argument and pass only GlobalObject&. We can
find everything we need via the global object anyway.
This commit is contained in:
Andreas Kling 2020-07-22 17:50:18 +02:00
parent 299824de73
commit aaf6014ae1
82 changed files with 161 additions and 160 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Bindings/LocationObject.cpp
View file

@ -40,9 +40,9 @@ LocationObject::LocationObject(JS::GlobalObject& global_object)
{
}
void LocationObject::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object)
void LocationObject::initialize(JS::GlobalObject& global_object)
{
Object::initialize(interpreter, global_object);
Object::initialize(global_object);
u8 attr = JS::Attribute::Writable | JS::Attribute::Enumerable;
define_native_property("href", href_getter, href_setter, attr);
define_native_property("host", host_getter, nullptr, attr);

2
Libraries/LibWeb/Bindings/LocationObject.h
View file

@ -37,7 +37,7 @@ class LocationObject final : public JS::Object {
public:
explicit LocationObject(JS::GlobalObject&);
virtual void initialize(JS::Interpreter&, JS::GlobalObject&) override;
virtual void initialize(JS::GlobalObject&) override;
virtual ~LocationObject() override;
private:

15
Libraries/LibWeb/Bindings/NavigatorObject.cpp
View file

@ -39,18 +39,19 @@ NavigatorObject::NavigatorObject(JS::GlobalObject& global_object)
{
}
void NavigatorObject::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object)
void NavigatorObject::initialize(JS::GlobalObject& global_object)
{
auto& heap = this->heap();
auto* languages = JS::Array::create(global_object);
languages->indexed_properties().append(js_string(heap(), "en-US"));
languages->indexed_properties().append(js_string(heap, "en-US"));
define_property("appCodeName", js_string(interpreter.heap(), "Mozilla"));
define_property("appName", js_string(interpreter.heap(), "Netscape"));
define_property("appVersion", js_string(interpreter.heap(), "4.0"));
define_property("appCodeName", js_string(heap, "Mozilla"));
define_property("appName", js_string(heap, "Netscape"));
define_property("appVersion", js_string(heap, "4.0"));
define_property("language", languages->get(0));
define_property("languages", languages);
define_property("platform", js_string(interpreter.heap(), "SerenityOS"));
define_property("product", js_string(interpreter.heap(), "Gecko"));
define_property("platform", js_string(heap, "SerenityOS"));
define_property("product", js_string(heap, "Gecko"));
define_native_property("userAgent", user_agent_getter, nullptr);
}

2
Libraries/LibWeb/Bindings/NavigatorObject.h
View file

@ -37,7 +37,7 @@ class NavigatorObject final : public JS::Object {
public:
NavigatorObject(JS::GlobalObject&);
virtual void initialize(JS::Interpreter&, JS::GlobalObject&) override;
virtual void initialize(JS::GlobalObject&) override;
virtual ~NavigatorObject() override;
private:

4
Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp
View file

@ -40,9 +40,9 @@ XMLHttpRequestConstructor::XMLHttpRequestConstructor(JS::GlobalObject& global_ob
{
}
void XMLHttpRequestConstructor::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object)
void XMLHttpRequestConstructor::initialize(JS::GlobalObject& global_object)
{
NativeFunction::initialize(interpreter, global_object);
NativeFunction::initialize(global_object);
define_property("length", JS::Value(1), JS::Attribute::Configurable);
define_property("UNSENT", JS::Value((i32)XMLHttpRequest::ReadyState::Unsent), JS::Attribute::Enumerable);

2
Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.h
View file

@ -33,7 +33,7 @@ namespace Web::Bindings {
class XMLHttpRequestConstructor final : public JS::NativeFunction {
public:
explicit XMLHttpRequestConstructor(JS::GlobalObject&);
virtual void initialize(JS::Interpreter&, JS::GlobalObject&) override;
virtual void initialize(JS::GlobalObject&) override;
virtual ~XMLHttpRequestConstructor() override;
virtual JS::Value call(JS::Interpreter&) override;

4
Libraries/LibWeb/Bindings/XMLHttpRequestPrototype.cpp
View file

@ -39,9 +39,9 @@ XMLHttpRequestPrototype::XMLHttpRequestPrototype(JS::GlobalObject& global_object
{
}
void XMLHttpRequestPrototype::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object)
void XMLHttpRequestPrototype::initialize(JS::GlobalObject& global_object)
{
Object::initialize(interpreter, global_object);
Object::initialize(global_object);
define_native_function("open", open, 2);
define_native_function("send", send, 0);
define_native_property("readyState", ready_state_getter, nullptr, JS::Attribute::Enumerable | JS::Attribute::Configurable);

2
Libraries/LibWeb/Bindings/XMLHttpRequestPrototype.h
View file

@ -35,7 +35,7 @@ class XMLHttpRequestPrototype final : public JS::Object {
public:
explicit XMLHttpRequestPrototype(JS::GlobalObject&);
virtual void initialize(JS::Interpreter&, JS::GlobalObject&) override;
virtual void initialize(JS::GlobalObject&) override;
virtual ~XMLHttpRequestPrototype() override;
private:

6
Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
View file

@ -365,7 +365,7 @@ static void generate_header(const IDL::Interface& interface)
out() << " JS_OBJECT(" << wrapper_class << ", " << wrapper_base_class << ");";
out() << "public:";
out() << " " << wrapper_class << "(JS::GlobalObject&, " << interface.name << "&);";
out() << " virtual void initialize(JS::Interpreter&, JS::GlobalObject&) override;";
out() << " virtual void initialize(JS::GlobalObject&) override;";
out() << " virtual ~" << wrapper_class << "() override;";
if (wrapper_base_class == "Wrapper") {
@ -444,10 +444,10 @@ void generate_implementation(const IDL::Interface& interface)
out() << "}";
// Implementation: Wrapper initialize()
out() << "void " << wrapper_class << "::initialize(JS::Interpreter& interpreter, JS::GlobalObject& global_object)";
out() << "void " << wrapper_class << "::initialize(JS::GlobalObject& global_object)";
out() << "{";
out() << " [[maybe_unused]] u8 default_attributes = JS::Attribute::Enumerable | JS::Attribute::Configurable;";
out() << " " << wrapper_base_class << "::initialize(interpreter, global_object);";
out() << " " << wrapper_base_class << "::initialize(global_object);";
for (auto& attribute : interface.attributes) {
out() << " define_native_property(\"" << attribute.name << "\", " << attribute.getter_callback_name << ", " << (attribute.readonly ? "nullptr" : attribute.setter_callback_name) << ", default_attributes);";