mirror of
https://github.com/RGBCube/serenity
synced 2025-07-24 23:07:34 +00:00
LibGUI: Add a ToolBarContainer widget and put most ToolBars in one
This mimics the Explorer toolbar container from Windows 2000 and looks pretty neat! :^)
This commit is contained in:
parent
5b6c2f3bd6
commit
ab336e895f
12 changed files with 179 additions and 18 deletions
|
@ -38,6 +38,7 @@
|
||||||
#include <LibGUI/StatusBar.h>
|
#include <LibGUI/StatusBar.h>
|
||||||
#include <LibGUI/TextBox.h>
|
#include <LibGUI/TextBox.h>
|
||||||
#include <LibGUI/ToolBar.h>
|
#include <LibGUI/ToolBar.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
#include <LibGUI/Window.h>
|
#include <LibGUI/Window.h>
|
||||||
#include <LibWeb/CSS/StyleResolver.h>
|
#include <LibWeb/CSS/StyleResolver.h>
|
||||||
#include <LibWeb/DOM/Element.h>
|
#include <LibWeb/DOM/Element.h>
|
||||||
|
@ -104,8 +105,9 @@ int main(int argc, char** argv)
|
||||||
|
|
||||||
bool bookmarksbar_enabled = true;
|
bool bookmarksbar_enabled = true;
|
||||||
|
|
||||||
auto& toolbar = widget.add<GUI::ToolBar>();
|
auto& toolbar_container = widget.add<GUI::ToolBarContainer>();
|
||||||
auto& bookmarksbar = widget.add<BookmarksBarWidget>(bookmarks_filename, bookmarksbar_enabled);
|
auto& toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
|
auto& bookmarksbar = toolbar_container.add<BookmarksBarWidget>(bookmarks_filename, bookmarksbar_enabled);
|
||||||
auto& html_widget = widget.add<Web::HtmlView>();
|
auto& html_widget = widget.add<Web::HtmlView>();
|
||||||
|
|
||||||
bookmarksbar.on_bookmark_click = [&](auto&, auto& url) {
|
bookmarksbar.on_bookmark_click = [&](auto&, auto& url) {
|
||||||
|
|
|
@ -52,6 +52,7 @@
|
||||||
#include <LibGUI/StatusBar.h>
|
#include <LibGUI/StatusBar.h>
|
||||||
#include <LibGUI/TextEditor.h>
|
#include <LibGUI/TextEditor.h>
|
||||||
#include <LibGUI/ToolBar.h>
|
#include <LibGUI/ToolBar.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
#include <LibGUI/TreeView.h>
|
#include <LibGUI/TreeView.h>
|
||||||
#include <LibGUI/Widget.h>
|
#include <LibGUI/Widget.h>
|
||||||
#include <LibGUI/Window.h>
|
#include <LibGUI/Window.h>
|
||||||
|
@ -237,12 +238,14 @@ int run_in_windowed_mode(RefPtr<Core::ConfigFile> config, String initial_locatio
|
||||||
|
|
||||||
auto& widget = window->set_main_widget<GUI::Widget>();
|
auto& widget = window->set_main_widget<GUI::Widget>();
|
||||||
widget.set_layout<GUI::VerticalBoxLayout>();
|
widget.set_layout<GUI::VerticalBoxLayout>();
|
||||||
widget.layout()->set_spacing(0);
|
widget.set_fill_with_background_color(true);
|
||||||
|
widget.layout()->set_spacing(2);
|
||||||
|
|
||||||
auto& main_toolbar = widget.add<GUI::ToolBar>();
|
auto& toolbar_container = widget.add<GUI::ToolBarContainer>();
|
||||||
auto& location_toolbar = widget.add<GUI::ToolBar>();
|
|
||||||
|
auto& main_toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
|
auto& location_toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
location_toolbar.layout()->set_margins({ 6, 3, 6, 3 });
|
location_toolbar.layout()->set_margins({ 6, 3, 6, 3 });
|
||||||
location_toolbar.set_preferred_size(0, 25);
|
|
||||||
|
|
||||||
auto& location_label = location_toolbar.add<GUI::Label>("Location: ");
|
auto& location_label = location_toolbar.add<GUI::Label>("Location: ");
|
||||||
location_label.size_to_fit();
|
location_label.size_to_fit();
|
||||||
|
|
|
@ -38,6 +38,7 @@
|
||||||
#include <LibGUI/Splitter.h>
|
#include <LibGUI/Splitter.h>
|
||||||
#include <LibGUI/TextEditor.h>
|
#include <LibGUI/TextEditor.h>
|
||||||
#include <LibGUI/ToolBar.h>
|
#include <LibGUI/ToolBar.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
#include <LibGUI/TreeView.h>
|
#include <LibGUI/TreeView.h>
|
||||||
#include <LibGUI/Window.h>
|
#include <LibGUI/Window.h>
|
||||||
#include <LibMarkdown/MDDocument.h>
|
#include <LibMarkdown/MDDocument.h>
|
||||||
|
@ -83,7 +84,8 @@ int main(int argc, char* argv[])
|
||||||
widget.set_layout<GUI::VerticalBoxLayout>();
|
widget.set_layout<GUI::VerticalBoxLayout>();
|
||||||
widget.layout()->set_spacing(0);
|
widget.layout()->set_spacing(0);
|
||||||
|
|
||||||
auto& toolbar = widget.add<GUI::ToolBar>();
|
auto& toolbar_container = widget.add<GUI::ToolBarContainer>();
|
||||||
|
auto& toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
|
|
||||||
auto& splitter = widget.add<GUI::HorizontalSplitter>();
|
auto& splitter = widget.add<GUI::HorizontalSplitter>();
|
||||||
|
|
||||||
|
|
|
@ -39,6 +39,7 @@
|
||||||
#include <LibGUI/StackWidget.h>
|
#include <LibGUI/StackWidget.h>
|
||||||
#include <LibGUI/TableView.h>
|
#include <LibGUI/TableView.h>
|
||||||
#include <LibGUI/ToolBar.h>
|
#include <LibGUI/ToolBar.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
#include <stdio.h>
|
#include <stdio.h>
|
||||||
#include <stdlib.h>
|
#include <stdlib.h>
|
||||||
|
|
||||||
|
@ -312,7 +313,8 @@ void IRCAppWindow::setup_widgets()
|
||||||
widget.set_layout<GUI::VerticalBoxLayout>();
|
widget.set_layout<GUI::VerticalBoxLayout>();
|
||||||
widget.layout()->set_spacing(0);
|
widget.layout()->set_spacing(0);
|
||||||
|
|
||||||
auto& toolbar = widget.add<GUI::ToolBar>();
|
auto& toolbar_container = widget.add<GUI::ToolBarContainer>();
|
||||||
|
auto& toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
toolbar.set_has_frame(false);
|
toolbar.set_has_frame(false);
|
||||||
toolbar.add_action(*m_change_nick_action);
|
toolbar.add_action(*m_change_nick_action);
|
||||||
toolbar.add_separator();
|
toolbar.add_separator();
|
||||||
|
|
|
@ -38,6 +38,7 @@
|
||||||
#include <LibGUI/MenuBar.h>
|
#include <LibGUI/MenuBar.h>
|
||||||
#include <LibGUI/MessageBox.h>
|
#include <LibGUI/MessageBox.h>
|
||||||
#include <LibGUI/ToolBar.h>
|
#include <LibGUI/ToolBar.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
#include <LibGUI/Window.h>
|
#include <LibGUI/Window.h>
|
||||||
#include <LibGfx/Bitmap.h>
|
#include <LibGfx/Bitmap.h>
|
||||||
#include <stdio.h>
|
#include <stdio.h>
|
||||||
|
@ -71,7 +72,8 @@ int main(int argc, char** argv)
|
||||||
root_widget.set_layout<GUI::VerticalBoxLayout>();
|
root_widget.set_layout<GUI::VerticalBoxLayout>();
|
||||||
root_widget.layout()->set_spacing(0);
|
root_widget.layout()->set_spacing(0);
|
||||||
|
|
||||||
auto& main_toolbar = root_widget.add<GUI::ToolBar>();
|
auto& toolbar_container = root_widget.add<GUI::ToolBarContainer>();
|
||||||
|
auto& main_toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
|
|
||||||
auto& widget = root_widget.add<QSWidget>();
|
auto& widget = root_widget.add<QSWidget>();
|
||||||
widget.on_scale_change = [&](int scale) {
|
widget.on_scale_change = [&](int scale) {
|
||||||
|
|
|
@ -46,15 +46,18 @@
|
||||||
#include <LibGUI/TextBox.h>
|
#include <LibGUI/TextBox.h>
|
||||||
#include <LibGUI/TextEditor.h>
|
#include <LibGUI/TextEditor.h>
|
||||||
#include <LibGUI/ToolBar.h>
|
#include <LibGUI/ToolBar.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
#include <LibGfx/Font.h>
|
#include <LibGfx/Font.h>
|
||||||
#include <string.h>
|
#include <string.h>
|
||||||
|
|
||||||
TextEditorWidget::TextEditorWidget()
|
TextEditorWidget::TextEditorWidget()
|
||||||
{
|
{
|
||||||
|
set_fill_with_background_color(true);
|
||||||
set_layout<GUI::VerticalBoxLayout>();
|
set_layout<GUI::VerticalBoxLayout>();
|
||||||
layout()->set_spacing(0);
|
layout()->set_spacing(2);
|
||||||
|
|
||||||
auto& toolbar = add<GUI::ToolBar>();
|
auto& toolbar_container = add<GUI::ToolBarContainer>();
|
||||||
|
auto& toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
m_editor = add<GUI::TextEditor>();
|
m_editor = add<GUI::TextEditor>();
|
||||||
m_editor->set_ruler_visible(true);
|
m_editor->set_ruler_visible(true);
|
||||||
m_editor->set_automatic_indentation_enabled(true);
|
m_editor->set_automatic_indentation_enabled(true);
|
||||||
|
|
|
@ -58,6 +58,7 @@
|
||||||
#include <LibGUI/TextBox.h>
|
#include <LibGUI/TextBox.h>
|
||||||
#include <LibGUI/TextEditor.h>
|
#include <LibGUI/TextEditor.h>
|
||||||
#include <LibGUI/ToolBar.h>
|
#include <LibGUI/ToolBar.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
#include <LibGUI/TreeView.h>
|
#include <LibGUI/TreeView.h>
|
||||||
#include <LibGUI/Widget.h>
|
#include <LibGUI/Widget.h>
|
||||||
#include <LibGUI/Window.h>
|
#include <LibGUI/Window.h>
|
||||||
|
@ -163,7 +164,8 @@ int main(int argc, char** argv)
|
||||||
|
|
||||||
open_project("/home/anon/js/javascript.files");
|
open_project("/home/anon/js/javascript.files");
|
||||||
|
|
||||||
auto& toolbar = widget.add<GUI::ToolBar>();
|
auto& toolbar_container = widget.add<GUI::ToolBarContainer>();
|
||||||
|
auto& toolbar = toolbar_container.add<GUI::ToolBar>();
|
||||||
|
|
||||||
auto selected_file_names = [&] {
|
auto selected_file_names = [&] {
|
||||||
Vector<String> files;
|
Vector<String> files;
|
||||||
|
|
|
@ -65,6 +65,7 @@ OBJS = \
|
||||||
TextDocument.o \
|
TextDocument.o \
|
||||||
TextEditor.o \
|
TextEditor.o \
|
||||||
ToolBar.o \
|
ToolBar.o \
|
||||||
|
ToolBarContainer.o \
|
||||||
TreeView.o \
|
TreeView.o \
|
||||||
UndoStack.o \
|
UndoStack.o \
|
||||||
Variant.o \
|
Variant.o \
|
||||||
|
|
|
@ -39,7 +39,7 @@ StatusBar::StatusBar(int label_count)
|
||||||
set_size_policy(SizePolicy::Fill, SizePolicy::Fixed);
|
set_size_policy(SizePolicy::Fill, SizePolicy::Fixed);
|
||||||
set_preferred_size(0, 20);
|
set_preferred_size(0, 20);
|
||||||
set_layout<HorizontalBoxLayout>();
|
set_layout<HorizontalBoxLayout>();
|
||||||
layout()->set_margins({ 0, 3, 0, 0 });
|
layout()->set_margins({ 0, 0, 0, 0 });
|
||||||
layout()->set_spacing(2);
|
layout()->set_spacing(2);
|
||||||
|
|
||||||
if (label_count < 1)
|
if (label_count < 1)
|
||||||
|
|
|
@ -39,10 +39,10 @@ ToolBar::ToolBar(Orientation orientation, int button_size)
|
||||||
{
|
{
|
||||||
if (orientation == Orientation::Horizontal) {
|
if (orientation == Orientation::Horizontal) {
|
||||||
set_size_policy(SizePolicy::Fill, SizePolicy::Fixed);
|
set_size_policy(SizePolicy::Fill, SizePolicy::Fixed);
|
||||||
set_preferred_size(0, button_size + 10);
|
set_preferred_size(0, button_size + 8);
|
||||||
} else {
|
} else {
|
||||||
set_size_policy(SizePolicy::Fixed, SizePolicy::Fill);
|
set_size_policy(SizePolicy::Fixed, SizePolicy::Fill);
|
||||||
set_preferred_size(button_size + 10, 0);
|
set_preferred_size(button_size + 8, 0);
|
||||||
}
|
}
|
||||||
set_layout<BoxLayout>(orientation);
|
set_layout<BoxLayout>(orientation);
|
||||||
layout()->set_spacing(0);
|
layout()->set_spacing(0);
|
||||||
|
@ -111,9 +111,9 @@ void ToolBar::paint_event(PaintEvent& event)
|
||||||
Painter painter(*this);
|
Painter painter(*this);
|
||||||
painter.add_clip_rect(event.rect());
|
painter.add_clip_rect(event.rect());
|
||||||
|
|
||||||
if (m_has_frame)
|
//if (m_has_frame)
|
||||||
Gfx::StylePainter::paint_surface(painter, rect(), palette(), x() != 0, y() != 0);
|
// Gfx::StylePainter::paint_surface(painter, rect(), palette(), x() != 0, y() != 0);
|
||||||
else
|
// else
|
||||||
painter.fill_rect(event.rect(), palette().button());
|
painter.fill_rect(event.rect(), palette().button());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
86
Libraries/LibGUI/ToolBarContainer.cpp
Normal file
86
Libraries/LibGUI/ToolBarContainer.cpp
Normal file
|
@ -0,0 +1,86 @@
|
||||||
|
/*
|
||||||
|
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
||||||
|
* All rights reserved.
|
||||||
|
*
|
||||||
|
* Redistribution and use in source and binary forms, with or without
|
||||||
|
* modification, are permitted provided that the following conditions are met:
|
||||||
|
*
|
||||||
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
||||||
|
* list of conditions and the following disclaimer.
|
||||||
|
*
|
||||||
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
||||||
|
* this list of conditions and the following disclaimer in the documentation
|
||||||
|
* and/or other materials provided with the distribution.
|
||||||
|
*
|
||||||
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
||||||
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
||||||
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
||||||
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
||||||
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
||||||
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
||||||
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
||||||
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
||||||
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
||||||
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <LibGUI/BoxLayout.h>
|
||||||
|
#include <LibGUI/Painter.h>
|
||||||
|
#include <LibGUI/ToolBarContainer.h>
|
||||||
|
#include <LibGfx/Palette.h>
|
||||||
|
#include <LibGfx/StylePainter.h>
|
||||||
|
|
||||||
|
namespace GUI {
|
||||||
|
|
||||||
|
void ToolBarContainer::did_add_toolbar(Widget& toolbar)
|
||||||
|
{
|
||||||
|
m_toolbars.append(toolbar);
|
||||||
|
int preferred_size = 4 + (m_toolbars.size() - 1) * 2;
|
||||||
|
|
||||||
|
for (auto& toolbar : m_toolbars) {
|
||||||
|
if (m_orientation == Gfx::Orientation::Horizontal)
|
||||||
|
preferred_size += toolbar.preferred_size().height();
|
||||||
|
else
|
||||||
|
preferred_size += toolbar.preferred_size().width();
|
||||||
|
}
|
||||||
|
|
||||||
|
if (m_orientation == Gfx::Orientation::Horizontal)
|
||||||
|
set_preferred_size(0, preferred_size);
|
||||||
|
else
|
||||||
|
set_preferred_size(preferred_size, 0);
|
||||||
|
}
|
||||||
|
|
||||||
|
ToolBarContainer::ToolBarContainer(Gfx::Orientation orientation)
|
||||||
|
: m_orientation(orientation)
|
||||||
|
{
|
||||||
|
set_fill_with_background_color(true);
|
||||||
|
|
||||||
|
set_frame_thickness(2);
|
||||||
|
set_frame_shape(Gfx::FrameShape::Box);
|
||||||
|
set_frame_shadow(Gfx::FrameShadow::Sunken);
|
||||||
|
|
||||||
|
if (m_orientation == Gfx::Orientation::Horizontal)
|
||||||
|
set_size_policy(SizePolicy::Fill, SizePolicy::Fixed);
|
||||||
|
else
|
||||||
|
set_size_policy(SizePolicy::Fixed, SizePolicy::Fill);
|
||||||
|
|
||||||
|
auto& layout = set_layout<VerticalBoxLayout>();
|
||||||
|
layout.set_spacing(2);
|
||||||
|
layout.set_margins({ 2, 2, 2, 2 });
|
||||||
|
}
|
||||||
|
|
||||||
|
void ToolBarContainer::paint_event(GUI::PaintEvent& event)
|
||||||
|
{
|
||||||
|
Painter painter(*this);
|
||||||
|
painter.add_clip_rect(event.rect());
|
||||||
|
|
||||||
|
for (auto& toolbar : m_toolbars) {
|
||||||
|
auto rect = toolbar.relative_rect();
|
||||||
|
painter.draw_line(rect.top_left().translated(0, -1), rect.top_right().translated(0, -1), palette().threed_highlight());
|
||||||
|
painter.draw_line(rect.bottom_left().translated(0, 1), rect.bottom_right().translated(0, 1), palette().threed_shadow1());
|
||||||
|
}
|
||||||
|
|
||||||
|
Frame::paint_event(event);
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
58
Libraries/LibGUI/ToolBarContainer.h
Normal file
58
Libraries/LibGUI/ToolBarContainer.h
Normal file
|
@ -0,0 +1,58 @@
|
||||||
|
/*
|
||||||
|
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
||||||
|
* All rights reserved.
|
||||||
|
*
|
||||||
|
* Redistribution and use in source and binary forms, with or without
|
||||||
|
* modification, are permitted provided that the following conditions are met:
|
||||||
|
*
|
||||||
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
||||||
|
* list of conditions and the following disclaimer.
|
||||||
|
*
|
||||||
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
||||||
|
* this list of conditions and the following disclaimer in the documentation
|
||||||
|
* and/or other materials provided with the distribution.
|
||||||
|
*
|
||||||
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
||||||
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
||||||
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
||||||
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
||||||
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
||||||
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
||||||
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
||||||
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
||||||
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
||||||
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#pragma once
|
||||||
|
|
||||||
|
#include <LibGUI/Frame.h>
|
||||||
|
#include <LibGUI/ToolBar.h>
|
||||||
|
|
||||||
|
namespace GUI {
|
||||||
|
|
||||||
|
class ToolBarContainer : public Frame {
|
||||||
|
C_OBJECT(ToolBarContainer);
|
||||||
|
|
||||||
|
public:
|
||||||
|
template<class T, class... Args>
|
||||||
|
inline T& add(Args&&... args)
|
||||||
|
{
|
||||||
|
auto& child = Frame::add<T>(forward<Args>(args)...);
|
||||||
|
did_add_toolbar(child);
|
||||||
|
return child;
|
||||||
|
}
|
||||||
|
|
||||||
|
private:
|
||||||
|
explicit ToolBarContainer(Gfx::Orientation = Gfx::Orientation::Horizontal);
|
||||||
|
|
||||||
|
virtual void paint_event(GUI::PaintEvent&) override;
|
||||||
|
|
||||||
|
void did_add_toolbar(Widget&);
|
||||||
|
|
||||||
|
Gfx::Orientation m_orientation { Gfx::Orientation::Horizontal };
|
||||||
|
|
||||||
|
NonnullRefPtrVector<Widget> m_toolbars;
|
||||||
|
};
|
||||||
|
|
||||||
|
}
|
Loading…
Add table
Add a link
Reference in a new issue