RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 14:07:42 +00:00
Code Issues Activity Actions

LanguageServers: Don't VERIFY that set_todo_entries callback exists

Browse source 
The callback may not exist if the CodeComprehensionEngine is running
in the context of tests (i.e CppLanguageServer -t).
This commit is contained in:
Itamar 2021-06-27 21:46:23 +03:00 • committed by Ali Mohammad Pur
parent 4123be7639
commit ab3aa0759a
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp
View file

@ -19,6 +19,7 @@ CodeComprehensionEngine::~CodeComprehensionEngine()
} }
void CodeComprehensionEngine::set_declarations_of_document(const String& filename, Vector<GUI::AutocompleteProvider::Declaration>&& declarations) void CodeComprehensionEngine::set_declarations_of_document(const String& filename, Vector<GUI::AutocompleteProvider::Declaration>&& declarations)
{ {
// Callback may not be configured if we're running tests
if (!set_declarations_of_document_callback) if (!set_declarations_of_document_callback)
return; return;
@ -34,7 +35,9 @@ void CodeComprehensionEngine::set_declarations_of_document(const String& filenam
void CodeComprehensionEngine::set_todo_entries_of_document(String const& filename, Vector<Cpp::Parser::TodoEntry>&& todo_entries) void CodeComprehensionEngine::set_todo_entries_of_document(String const& filename, Vector<Cpp::Parser::TodoEntry>&& todo_entries)
{ {
VERIFY(set_todo_entries_of_document_callback); // Callback may not be configured if we're running tests
if (!set_todo_entries_of_document_callback)
return;
set_todo_entries_of_document_callback(filename, move(todo_entries)); set_todo_entries_of_document_callback(filename, move(todo_entries));
} }