RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

TerminalSettings: Expose a CheckBox controlling scrollbar visibility

Browse source
This commit is contained in:
Brian Gianforcaro 2022-01-14 20:40:30 -08:00 • committed by Andreas Kling
parent 0e26ba59f7
commit ab4035e227
3 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/TerminalSettings/TerminalSettingsMain.gml
View file

@ -53,6 +53,11 @@
margins: [16, 8, 8] margins: [16, 8, 8]
} }
@GUI::CheckBox {
name: "terminal_show_scrollbar"
text: "Show scrollbar"
}
@GUI::SpinBox { @GUI::SpinBox {
name: "history_size_spinbox" name: "history_size_spinbox"
min: 0 min: 0

11
Userland/Applications/TerminalSettings/TerminalSettingsWidget.cpp
View file

@ -74,6 +74,15 @@ TerminalSettingsMainWidget::TerminalSettingsMainWidget()
m_max_history_size = value; m_max_history_size = value;
Config::write_i32("Terminal", "Terminal", "MaxHistorySize", static_cast<i32>(m_max_history_size)); Config::write_i32("Terminal", "Terminal", "MaxHistorySize", static_cast<i32>(m_max_history_size));
}; };
m_show_scrollbar = Config::read_bool("Terminal", "Terminal", "ShowScrollBar", true);
m_orignal_show_scrollbar = m_show_scrollbar;
auto& show_scrollbar_checkbox = *find_descendant_of_type_named<GUI::CheckBox>("terminal_show_scrollbar");
show_scrollbar_checkbox.on_checked = [&](bool show_scrollbar) {
m_show_scrollbar = show_scrollbar;
Config::write_bool("Terminal", "Terminal", "ShowScrollBar", show_scrollbar);
};
show_scrollbar_checkbox.set_checked(m_show_scrollbar);
} }
TerminalSettingsViewWidget::TerminalSettingsViewWidget() TerminalSettingsViewWidget::TerminalSettingsViewWidget()
@ -175,12 +184,14 @@ String TerminalSettingsMainWidget::stringify_bell(VT::TerminalWidget::BellMode b
void TerminalSettingsMainWidget::apply_settings() void TerminalSettingsMainWidget::apply_settings()
{ {
m_original_max_history_size = m_max_history_size; m_original_max_history_size = m_max_history_size;
m_orignal_show_scrollbar = m_show_scrollbar;
m_original_bell_mode = m_bell_mode; m_original_bell_mode = m_bell_mode;
write_back_settings(); write_back_settings();
} }
void TerminalSettingsMainWidget::write_back_settings() const void TerminalSettingsMainWidget::write_back_settings() const
{ {
Config::write_i32("Terminal", "Terminal", "MaxHistorySize", static_cast<i32>(m_original_max_history_size)); Config::write_i32("Terminal", "Terminal", "MaxHistorySize", static_cast<i32>(m_original_max_history_size));
Config::write_bool("Terminal", "Terminal", "ShowScrollBar", m_orignal_show_scrollbar);
Config::write_string("Terminal", "Window", "Bell", stringify_bell(m_original_bell_mode)); Config::write_string("Terminal", "Window", "Bell", stringify_bell(m_original_bell_mode));
} }

2
Userland/Applications/TerminalSettings/TerminalSettingsWidget.h
View file

@ -28,9 +28,11 @@ private:
VT::TerminalWidget::BellMode m_bell_mode = VT::TerminalWidget::BellMode::Disabled; VT::TerminalWidget::BellMode m_bell_mode = VT::TerminalWidget::BellMode::Disabled;
size_t m_max_history_size; size_t m_max_history_size;
bool m_show_scrollbar { true };
VT::TerminalWidget::BellMode m_original_bell_mode; VT::TerminalWidget::BellMode m_original_bell_mode;
size_t m_original_max_history_size; size_t m_original_max_history_size;
bool m_orignal_show_scrollbar { true };
}; };
class TerminalSettingsViewWidget final : public GUI::SettingsWindow::Tab { class TerminalSettingsViewWidget final : public GUI::SettingsWindow::Tab {