RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

LibWeb: Use StringView instead of String in SVG::AttributeParser

Browse source 
This saves copying the string data, since the AttributeParser is always
temporary.
This commit is contained in:
Sam Atkins 2022-02-11 19:10:09 +00:00 • committed by Andreas Kling
parent 2fad940b0b
commit ab440b3e50
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/SVG/AttributeParser.cpp
View file

@ -11,7 +11,7 @@
namespace Web::SVG { namespace Web::SVG {
AttributeParser::AttributeParser(String source) AttributeParser::AttributeParser(StringView source)
: m_source(move(source)) : m_source(move(source))
{ {
} }

4
Userland/Libraries/LibWeb/SVG/AttributeParser.h
View file

@ -35,7 +35,7 @@ struct PathInstruction {
class AttributeParser final { class AttributeParser final {
public: public:
AttributeParser(String source); AttributeParser(StringView source);
~AttributeParser() = default; ~AttributeParser() = default;
Vector<PathInstruction> parse_path_data(); Vector<PathInstruction> parse_path_data();
@ -85,7 +85,7 @@ private:
char ch() const { return m_source[m_cursor]; } char ch() const { return m_source[m_cursor]; }
char consume() { return m_source[m_cursor++]; } char consume() { return m_source[m_cursor++]; }
String m_source; StringView m_source;
size_t m_cursor { 0 }; size_t m_cursor { 0 };
Vector<PathInstruction> m_instructions; Vector<PathInstruction> m_instructions;
}; };