RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:18:11 +00:00
Code Issues Activity Actions

LibJS: Rewrite Parser.parse_object_expression()

Browse source 
This rewrite drastically increases the accuracy of object literals.
Additionally, an "assertIsSyntaxError" function has been added to
test-common.js to assist in testing syntax errors.
This commit is contained in:
Matthew Olsson 2020-05-28 22:50:06 -07:00 • committed by Andreas Kling
parent 05b7fec517
commit ab576e610c
5 changed files with 138 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibJS/AST.h
View file

@ -796,7 +796,7 @@ public:
Spread,
};
ObjectProperty(NonnullRefPtr<Expression> key, NonnullRefPtr<Expression> value, Type property_type)
ObjectProperty(NonnullRefPtr<Expression> key, RefPtr<Expression> value, Type property_type)
: m_key(move(key))
, m_value(move(value))
, m_property_type(property_type)
@ -804,7 +804,11 @@ public:
}
const Expression& key() const { return m_key; }
const Expression& value() const { return m_value; }
const Expression& value() const
{
ASSERT(m_value);
return *m_value;
}
Type type() const { return m_property_type; }
@ -815,7 +819,7 @@ private:
virtual const char* class_name() const override { return "ObjectProperty"; }
NonnullRefPtr<Expression> m_key;
NonnullRefPtr<Expression> m_value;
RefPtr<Expression> m_value;
Type m_property_type;
};