RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:17:35 +00:00
Code Issues Activity Actions

LibJS: Rewrite Parser.parse_object_expression()

Browse source 
This rewrite drastically increases the accuracy of object literals.
Additionally, an "assertIsSyntaxError" function has been added to
test-common.js to assist in testing syntax errors.
This commit is contained in:
Matthew Olsson 2020-05-28 22:50:06 -07:00 • committed by Andreas Kling
parent 05b7fec517
commit ab576e610c
5 changed files with 138 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibJS/Tests/object-basic.js
View file

@ -66,6 +66,17 @@ try {
assert(a[2] === 3);
assert(o4.test === undefined);
assertIsSyntaxError("({ get ...foo })");
assertIsSyntaxError("({ get... foo })");
assertIsSyntaxError("({ get foo })");
assertIsSyntaxError("({ get foo: bar })");
assertIsSyntaxError("({ get [foo]: bar })");
assertIsSyntaxError("({ get ...[foo] })");
assertIsSyntaxError("({ get foo(bar) {} })");
assertIsSyntaxError("({ set foo() {} })");
assertIsSyntaxError("({ set foo(bar, baz) {} })");
assertIsSyntaxError("({ ...foo: bar })");
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e);

12
Libraries/LibJS/Tests/test-common.js
View file

@ -50,6 +50,18 @@ function assertThrowsError(testFunction, options) {
}
}
/**
* Ensures the provided JavaScript source code results in a SyntaxError
* @param {string} source The JavaScript source code to compile
*/
function assertIsSyntaxError(source) {
assertThrowsError(() => {
new Function(source)();
}, {
error: SyntaxError,
});
}
/**
* Ensures the provided arrays contain exactly the same items.
* @param {Array} a First array