RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:08:12 +00:00
Code Issues Activity Actions

Kernel: Remove the enabled concept of IRQ handlers

Browse source 
An IRQ handler should always be ready to respond to any IRQ.
We must remember that hardware can generate IRQs without any interaction
from our code at all. Ignoring IRQs in such cases is obviously not the
right thing to do.
This commit is contained in:
Liav A 2020-08-28 00:30:06 +03:00 • committed by Andreas Kling
parent a431108ab6
commit ab87d42200
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/Interrupts/SharedIRQHandler.cpp
View file

@ -98,11 +98,8 @@ void SharedIRQHandler::handle_interrupt(const RegisterState& regs)
dbg() << "Going for Interrupt Handling @ " << i << ", Shared Interrupt " << interrupt_number();
#endif
ASSERT(handler != nullptr);
if (handler->is_enabled()) {
handler->increment_invoking_counter();
handler->handle_interrupt(regs);
}
handler->increment_invoking_counter();
handler->handle_interrupt(regs);
#ifdef INTERRUPT_DEBUG
dbg() << "Going for Interrupt Handling @ " << i << ", Shared Interrupt " << interrupt_number() << " - End";
#endif