RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:37:44 +00:00
Code Issues Activity Actions

AK+Kernel: Handle allocation failures in Device::try_make_request

Browse source 
This adds try_* methods to AK::DoublyLinkedList and updates the Device
class to use those to gracefully handle allocation failures.

Refs #6369.
This commit is contained in:
Gunnar Beutner 2022-11-01 10:17:26 +01:00 • committed by Linus Groh
parent b33834ca3a
commit ab8b043684
2 changed files with 28 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

33
AK/DoublyLinkedList.h
View file

@ -7,6 +7,7 @@
#pragma once
#include <AK/Assertions.h>
#include <AK/Error.h>
#include <AK/Find.h>
#include <AK/StdLibExtras.h>
@ -91,42 +92,62 @@ public:
}
template<typename U>
void append(U&& value)
ErrorOr<void> try_append(U&& value)
{
static_assert(
requires { T(value); }, "Conversion operator is missing.");
auto* node = new Node(forward<U>(value));
auto* node = new (nothrow) Node(forward<U>(value));
if (!node)
return Error::from_errno(ENOMEM);
if (!m_head) {
VERIFY(!m_tail);
m_head = node;
m_tail = node;
return;
return {};
}
VERIFY(m_tail);
VERIFY(!node->next);
m_tail->next = node;
node->prev = m_tail;
m_tail = node;
return {};
}
template<typename U>
void prepend(U&& value)
ErrorOr<void> try_prepend(U&& value)
{
static_assert(IsSame<T, U>);
auto* node = new Node(forward<U>(value));
auto* node = new (nothrow) Node(forward<U>(value));
if (!node)
return Error::from_errno(ENOMEM);
if (!m_head) {
VERIFY(!m_tail);
m_head = node;
m_tail = node;
return;
return {};
}
VERIFY(m_tail);
VERIFY(!node->prev);
m_head->prev = node;
node->next = m_head;
m_head = node;
return {};
}
#ifndef KERNEL
template<typename U>
void append(U&& value)
{
MUST(try_append(forward<U>(value)));
}
template<typename U>
void prepend(U&& value)
{
MUST(try_prepend(forward<U>(value)));
}
#endif
[[nodiscard]] bool contains_slow(const T& value) const
{
return find(value) != end();