RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-19 00:25:07 +00:00
Code Issues Activity Actions

LibIPC+Everywhere: Change IPC::encode's return type to ErrorOr

Browse source 
In doing so, this removes all uses of the Encoder's stream operator,
except for where it is currently still used in the generated IPC code.
So the stream operator currently discards any errors, which is the
existing behavior. A subsequent commit will propagate the errors.
This commit is contained in:
Timothy Flynn 2023-01-01 23:37:35 -05:00 • committed by Andreas Kling
parent d0f3f3d5ff
commit ab99ed5fba
29 changed files with 224 additions and 238 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Userland/Libraries/LibSQL/Value.cpp
View file

@ -814,37 +814,32 @@ ResultOr<NonnullRefPtr<TupleDescriptor>> Value::infer_tuple_descriptor(Vector<Va
}
template<>
bool IPC::encode(Encoder& encoder, SQL::Value const& value)
ErrorOr<void> IPC::encode(Encoder& encoder, SQL::Value const& value)
{
auto type_flags = encode_type_flags(value);
encoder << type_flags;
TRY(encoder.encode(type_flags));
if (value.is_null())
return true;
return {};
switch (value.type()) {
case SQL::SQLType::Null:
break;
return {};
case SQL::SQLType::Text:
encoder << value.to_deprecated_string();
break;
return encoder.encode(value.to_deprecated_string());
case SQL::SQLType::Integer:
SQL::downsize_integer(value, [&](auto integer, auto) {
encoder << integer;
return SQL::downsize_integer(value, [&](auto integer, auto) {
return encoder.encode(integer);
});
break;
case SQL::SQLType::Float:
encoder << value.to_double().value();
break;
return encoder.encode(value.to_double().value());
case SQL::SQLType::Boolean:
encoder << value.to_bool().value();
break;
return encoder.encode(value.to_bool().value());
case SQL::SQLType::Tuple:
encoder << value.to_vector().value();
break;
return encoder.encode(value.to_vector().value());
}
return true;
VERIFY_NOT_REACHED();
}
template<>