RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:17:34 +00:00
Code Issues Activity Actions

LibWeb: Use HashMap instead of Vector to store grid areas in GFC

Browse source 
Grid areas are accessed by their name (string) so HashMap is more
appropriate data structure to store them.
This commit is contained in:
Aliaksandr Kalenik 2023-05-28 22:02:53 +03:00 • committed by Andreas Kling
parent dfde972baf
commit ac280277b7
2 changed files with 26 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Layout/GridFormattingContext.h
View file

@ -160,7 +160,8 @@ private:
size_t column_start { 0 };
size_t column_end { 1 };
};
Vector<GridArea> m_valid_grid_areas;
HashMap<String, GridArea> m_grid_areas;
Vector<TemporaryTrack> m_grid_rows;
Vector<TemporaryTrack> m_grid_columns;
@ -216,8 +217,7 @@ private:
int count_of_repeated_auto_fill_or_fit_tracks(Vector<CSS::ExplicitGridTrack> const& track_list, AvailableSpace const&);
int get_count_of_tracks(Vector<CSS::ExplicitGridTrack> const&, AvailableSpace const&);
void build_valid_grid_areas();
int find_valid_grid_area(String const& needle);
void build_grid_areas();
void place_grid_items(AvailableSpace const& available_space);
void place_item_with_row_and_column_position(Box const& child_box);