RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:37:35 +00:00
Code Issues Activity Actions

LibWeb: Remove CalculatedStyleValue from Time

Browse source 
Time also isn't used anywhere yet, hooray!
This commit is contained in:
Sam Atkins 2023-03-30 15:55:02 +01:00 • committed by Andreas Kling
parent bf915fdfd7
commit ac4350748e
2 changed files with 3 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Userland/Libraries/LibWeb/CSS/Time.cpp
View file

@ -1,11 +1,11 @@
/* /*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org> * Copyright (c) 2022-2023, Sam Atkins <atkinssj@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#include "Time.h" #include "Time.h"
#include <LibWeb/CSS/StyleValue.h> #include <LibWeb/CSS/Percentage.h>
namespace Web::CSS { namespace Web::CSS {
@ -21,13 +21,6 @@ Time::Time(float value, Type type)
{ {
} }
Time Time::make_calculated(NonnullRefPtr<CalculatedStyleValue> calculated_style_value)
{
Time frequency { 0, Type::Calculated };
frequency.m_calculated_style = move(calculated_style_value);
return frequency;
}
Time Time::make_seconds(float value) Time Time::make_seconds(float value)
{ {
return { value, Type::S }; return { value, Type::S };
@ -35,23 +28,17 @@ Time Time::make_seconds(float value)
Time Time::percentage_of(Percentage const& percentage) const Time Time::percentage_of(Percentage const& percentage) const
{ {
VERIFY(!is_calculated());
return Time { percentage.as_fraction() * m_value, m_type }; return Time { percentage.as_fraction() * m_value, m_type };
} }
ErrorOr<String> Time::to_string() const ErrorOr<String> Time::to_string() const
{ {
if (is_calculated())
return m_calculated_style->to_string();
return String::formatted("{}{}", m_value, unit_name()); return String::formatted("{}{}", m_value, unit_name());
} }
float Time::to_seconds() const float Time::to_seconds() const
{ {
switch (m_type) { switch (m_type) {
case Type::Calculated:
return m_calculated_style->resolve_time()->to_seconds();
case Type::S: case Type::S:
return m_value; return m_value;
case Type::Ms: case Type::Ms:
@ -63,8 +50,6 @@ float Time::to_seconds() const
StringView Time::unit_name() const StringView Time::unit_name() const
{ {
switch (m_type) { switch (m_type) {
case Type::Calculated:
return "calculated"sv;
case Type::S: case Type::S:
return "s"sv; return "s"sv;
case Type::Ms: case Type::Ms:
@ -83,10 +68,4 @@ Optional<Time::Type> Time::unit_from_name(StringView name)
return {}; return {};
} }
NonnullRefPtr<CalculatedStyleValue> Time::calculated_style_value() const
{
VERIFY(!m_calculated_style.is_null());
return *m_calculated_style;
}
} }

11
Userland/Libraries/LibWeb/CSS/Time.h
View file

@ -1,12 +1,11 @@
/* /*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org> * Copyright (c) 2022-2023, Sam Atkins <atkinssj@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#pragma once #pragma once
#include <AK/RefPtr.h>
#include <AK/String.h> #include <AK/String.h>
#include <LibWeb/Forward.h> #include <LibWeb/Forward.h>
@ -15,7 +14,6 @@ namespace Web::CSS {
class Time { class Time {
public: public:
enum class Type { enum class Type {
Calculated,
S, S,
Ms, Ms,
}; };
@ -24,20 +22,14 @@ public:
Time(int value, Type type); Time(int value, Type type);
Time(float value, Type type); Time(float value, Type type);
static Time make_calculated(NonnullRefPtr<CalculatedStyleValue>);
static Time make_seconds(float); static Time make_seconds(float);
Time percentage_of(Percentage const&) const; Time percentage_of(Percentage const&) const;
bool is_calculated() const { return m_type == Type::Calculated; }
NonnullRefPtr<CalculatedStyleValue> calculated_style_value() const;
ErrorOr<String> to_string() const; ErrorOr<String> to_string() const;
float to_seconds() const; float to_seconds() const;
bool operator==(Time const& other) const bool operator==(Time const& other) const
{ {
if (is_calculated())
return m_calculated_style == other.m_calculated_style;
return m_type == other.m_type && m_value == other.m_value; return m_type == other.m_type && m_value == other.m_value;
} }
@ -46,7 +38,6 @@ private:
Type m_type; Type m_type;
float m_value { 0 }; float m_value { 0 };
RefPtr<CalculatedStyleValue> m_calculated_style;
}; };
} }