RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:17:34 +00:00
Code Issues Activity Actions

LibJS/JIT: Compile the PutPrivateById instruction

Browse source
This commit is contained in:
Simon Wanner 2023-10-29 22:20:47 +01:00 • committed by Andreas Kling
parent 81697549b7
commit ac43d3f6db
3 changed files with 25 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -717,6 +717,9 @@ public:
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const; ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const; DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const;
Register base() const { return m_base; }
IdentifierTableIndex property() const { return m_property; }
private: private:
Register m_base; Register m_base;
IdentifierTableIndex m_property; IdentifierTableIndex m_property;

20
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -1507,6 +1507,26 @@ void Compiler::compile_put_by_id_with_this(Bytecode::Op::PutByIdWithThis const&
check_exception(); check_exception();
} }
static Value cxx_put_private_by_id(VM& vm, Value base, Value value, DeprecatedFlyString const& name)
{
auto object = TRY_OR_SET_EXCEPTION(base.to_object(vm));
auto private_reference = make_private_reference(vm, object, name);
TRY_OR_SET_EXCEPTION(private_reference.put_value(vm, value));
return value;
}
void Compiler::compile_put_private_by_id(Bytecode::Op::PutPrivateById const& op)
{
load_vm_register(ARG1, op.base());
load_vm_register(ARG2, Bytecode::Register::accumulator());
m_assembler.mov(
Assembler::Operand::Register(ARG3),
Assembler::Operand::Imm(bit_cast<u64>(&m_bytecode_executable.get_identifier(op.property()))));
native_call((void*)cxx_put_private_by_id);
store_vm_register(Bytecode::Register::accumulator(), RET);
check_exception();
}
void Compiler::jump_to_exit() void Compiler::jump_to_exit()
{ {
m_assembler.jump(m_exit_label); m_assembler.jump(m_exit_label);

3
Userland/Libraries/LibJS/JIT/Compiler.h
View file

@ -125,7 +125,8 @@ private:
O(GetByIdWithThis, get_by_id_with_this) \ O(GetByIdWithThis, get_by_id_with_this) \
O(GetByValueWithThis, get_by_value_with_this) \ O(GetByValueWithThis, get_by_value_with_this) \
O(DeleteByIdWithThis, delete_by_id_with_this) \ O(DeleteByIdWithThis, delete_by_id_with_this) \
O(PutByIdWithThis, put_by_id_with_this) O(PutByIdWithThis, put_by_id_with_this) \
O(PutPrivateById, put_private_by_id)
# define DECLARE_COMPILE_OP(OpTitleCase, op_snake_case) \ # define DECLARE_COMPILE_OP(OpTitleCase, op_snake_case) \
void compile_##op_snake_case(Bytecode::Op::OpTitleCase const&); void compile_##op_snake_case(Bytecode::Op::OpTitleCase const&);