RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 11:17:43 +00:00
Code Issues Activity Actions

LibDebug: Support addrx*, strx* and rnglistx forms

Browse source 
These forms were introduced in DWARF5, and have a fair deal of
advantages over the more traditional encodings: they reduce the size of
the binary and the number of relocations.

GCC does not emit these with `-g1` by default, but Clang does at all
debug levels.
This commit is contained in:
Daniel Bertalan 2021-10-09 17:38:26 +02:00 • committed by Linus Groh
parent 8e5b70a0ba
commit ac53569bd1
7 changed files with 213 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

74
Userland/Libraries/LibDebug/Dwarf/DwarfInfo.cpp
View file

@ -23,6 +23,8 @@ DwarfInfo::DwarfInfo(ELF::Image const& elf)
m_debug_line_data = section_data(".debug_line"sv);
m_debug_line_strings_data = section_data(".debug_line_str"sv);
m_debug_range_lists_data = section_data(".debug_rnglists"sv);
m_debug_str_offsets_data = section_data(".debug_str_offsets"sv);
m_debug_addr_data = section_data(".debug_addr"sv);
populate_compilation_units();
}
@ -230,6 +232,78 @@ AttributeValue DwarfInfo::get_attribute_value(AttributeDataForm form, ssize_t im
value.m_data.as_signed = implicit_const_value;
break;
}
case AttributeDataForm::StrX1: {
u8 index;
debug_info_stream >> index;
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::String;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::StrX2: {
u16 index;
debug_info_stream >> index;
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::String;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::StrX4: {
u32 index;
debug_info_stream >> index;
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::String;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::StrX: {
size_t index;
debug_info_stream.read_LEB128_unsigned(index);
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::String;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::AddrX1: {
u8 index;
debug_info_stream >> index;
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::Address;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::AddrX2: {
u16 index;
debug_info_stream >> index;
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::Address;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::AddrX4: {
u32 index;
debug_info_stream >> index;
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::Address;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::AddrX: {
size_t index;
debug_info_stream.read_LEB128_unsigned(index);
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::Address;
value.m_data.as_unsigned = index;
break;
}
case AttributeDataForm::RngListX: {
size_t index;
debug_info_stream.read_LEB128_unsigned(index);
VERIFY(!debug_info_stream.has_any_error());
value.m_type = AttributeValue::Type::UnsignedNumber;
value.m_data.as_unsigned = index;
break;
}
default:
dbgln("Unimplemented AttributeDataForm: {}", (u32)form);
VERIFY_NOT_REACHED();