RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:27:39 +00:00
Code Issues Activity Actions

HackStudio: Abstract away language-server details

Browse source 
This commit moves all the logic that deals with the language server
(from HackStudio) into a LanguageClient class, provides some functions
to make constructing them easier, and makes all language servers use a
singular IPC definition.
Also fixes the FIXME about making the autocompletion async.
This makes adding language servers in the future significantly less
duplicate-y, and significantly easier :^)
This commit is contained in:
AnotherTest 2020-10-02 03:01:33 +03:30 • committed by Andreas Kling
parent 44f9637e20
commit ac5e08a541
17 changed files with 291 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

5
DevTools/HackStudio/LanguageClients/CMakeLists.txt
View file

@ -1 +1,4 @@
add_subdirectory(Cpp)
set(GENERATED_SOURCES
../../LanguageServers/LanguageServerEndpoint.h
../../LanguageServers/LanguageClientEndpoint.h
)

4
DevTools/HackStudio/LanguageClients/Cpp/CMakeLists.txt
View file

@ -1,4 +0,0 @@
set(GENERATED_SOURCES
../../LanguageServers/Cpp/CppLanguageServerEndpoint.h
../../LanguageServers/Cpp/CppLanguageClientEndpoint.h
)

43
DevTools/HackStudio/LanguageClients/Cpp/ServerConnection.h → DevTools/HackStudio/LanguageClients/ServerConnections.h
View file

@ -26,35 +26,28 @@
#pragma once
#include "../LanguageClient.h"
#include <AK/LexicalPath.h>
#include <DevTools/HackStudio/LanguageServers/Cpp/CppLanguageClientEndpoint.h>
#include <DevTools/HackStudio/LanguageServers/Cpp/CppLanguageServerEndpoint.h>
#include <DevTools/HackStudio/LanguageServers/LanguageClientEndpoint.h>
#include <DevTools/HackStudio/LanguageServers/LanguageServerEndpoint.h>
#include <LibIPC/ServerConnection.h>
#define LANGUAGE_CLIENT(namespace_, socket_name) \
namespace namespace_ { \
class ServerConnection : public HackStudio::ServerConnection { \
C_OBJECT(ServerConnection) \
private: \
ServerConnection(const String& project_path) \
: HackStudio::ServerConnection("/tmp/portal/language/" #socket_name, project_path) \
{ \
} \
}; \
}
namespace LanguageClients {
namespace Cpp {
class ServerConnection : public IPC::ServerConnection<CppLanguageClientEndpoint, CppLanguageServerEndpoint>
, public CppLanguageClientEndpoint {
C_OBJECT(ServerConnection)
public:
virtual void handshake() override
{
auto response = send_sync<Messages::CppLanguageServer::Greet>(m_project_path.string());
set_my_client_id(response->client_id());
}
private:
ServerConnection(const String& project_path)
: IPC::ServerConnection<CppLanguageClientEndpoint, CppLanguageServerEndpoint>(*this, "/tmp/portal/language/cpp")
, m_project_path(project_path)
{
}
virtual void handle(const Messages::CppLanguageClient::Dummy&) override { }
LexicalPath m_project_path;
};
LANGUAGE_CLIENT(Cpp, cpp)
}
}
#undef LANGUAGE_CLIENT