RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:07:45 +00:00
Code Issues Activity Actions

LibJS: Fix length of PlainDateTime.withPlainTime

Browse source 
withPlainTime's argument is optional, so the length of the function is
actually 0.
This commit is contained in:
Luke Wilde 2022-11-03 20:54:54 +00:00 • committed by Linus Groh
parent b26b18a0bc
commit ac67077b57
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimePrototype.cpp
View file

@ -59,7 +59,7 @@ void PlainDateTimePrototype::initialize(Realm& realm)
u8 attr = Attribute::Writable | Attribute::Configurable; u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(realm, vm.names.with, with, 1, attr); define_native_function(realm, vm.names.with, with, 1, attr);
define_native_function(realm, vm.names.withPlainTime, with_plain_time, 1, attr); define_native_function(realm, vm.names.withPlainTime, with_plain_time, 0, attr);
define_native_function(realm, vm.names.withPlainDate, with_plain_date, 1, attr); define_native_function(realm, vm.names.withPlainDate, with_plain_date, 1, attr);
define_native_function(realm, vm.names.withCalendar, with_calendar, 1, attr); define_native_function(realm, vm.names.withCalendar, with_calendar, 1, attr);
define_native_function(realm, vm.names.add, add, 1, attr); define_native_function(realm, vm.names.add, add, 1, attr);

4
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.prototype.withPlainTime.js
View file

@ -1,6 +1,6 @@
describe("correct behavior", () => { describe("correct behavior", () => {
test("length is 1", () => { test("length is 0", () => {
expect(Temporal.PlainDateTime.prototype.withPlainTime).toHaveLength(1); expect(Temporal.PlainDateTime.prototype.withPlainTime).toHaveLength(0);
}); });
test("basic functionality", () => { test("basic functionality", () => {