RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 01:47:36 +00:00
Code Issues Activity Actions

Kernel: Make all syscall functions return KResultOr<T>

Browse source 
This makes it a lot easier to return errors since we no longer have to
worry about negating EFOO errors and can just return them flat.
This commit is contained in:
Andreas Kling 2021-03-01 13:49:16 +01:00
parent 9af1e1a3bf
commit ac71775de5
70 changed files with 747 additions and 742 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Kernel/Syscalls/profiling.cpp
View file

@ -32,32 +32,32 @@
namespace Kernel {
int Process::sys$profiling_enable(pid_t pid)
KResultOr<int> Process::sys$profiling_enable(pid_t pid)
{
REQUIRE_NO_PROMISES;
ScopedSpinLock lock(g_processes_lock);
auto process = Process::from_pid(pid);
if (!process)
return -ESRCH;
return ESRCH;
if (process->is_dead())
return -ESRCH;
return ESRCH;
if (!is_superuser() && process->uid() != m_euid)
return -EPERM;
return EPERM;
process->ensure_perf_events();
process->set_profiling(true);
return 0;
}
int Process::sys$profiling_disable(pid_t pid)
KResultOr<int> Process::sys$profiling_disable(pid_t pid)
{
ScopedSpinLock lock(g_processes_lock);
auto process = Process::from_pid(pid);
if (!process)
return -ESRCH;
return ESRCH;
if (!is_superuser() && process->uid() != m_euid)
return -EPERM;
return EPERM;
if (!process->is_profiling())
return -EINVAL;
return EINVAL;
process->set_profiling(false);
return 0;
}