RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:07:35 +00:00
Code Issues Activity Actions

Kernel: Make all syscall functions return KResultOr<T>

Browse source 
This makes it a lot easier to return errors since we no longer have to
worry about negating EFOO errors and can just return them flat.
This commit is contained in:
Andreas Kling 2021-03-01 13:49:16 +01:00
parent 9af1e1a3bf
commit ac71775de5
70 changed files with 747 additions and 742 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Kernel/Syscalls/stat.cpp
View file

@ -31,25 +31,25 @@
namespace Kernel {
int Process::sys$fstat(int fd, Userspace<stat*> user_statbuf)
KResultOr<int> Process::sys$fstat(int fd, Userspace<stat*> user_statbuf)
{
REQUIRE_PROMISE(stdio);
auto description = file_description(fd);
if (!description)
return -EBADF;
return EBADF;
stat buffer = {};
int rc = description->stat(buffer);
if (!copy_to_user(user_statbuf, &buffer))
return -EFAULT;
return EFAULT;
return rc;
}
int Process::sys$stat(Userspace<const Syscall::SC_stat_params*> user_params)
KResultOr<int> Process::sys$stat(Userspace<const Syscall::SC_stat_params*> user_params)
{
REQUIRE_PROMISE(rpath);
Syscall::SC_stat_params params;
if (!copy_from_user(&params, user_params))
return -EFAULT;
return EFAULT;
auto path = get_syscall_path_argument(params.path);
if (path.is_error())
return path.error();
@ -61,7 +61,7 @@ int Process::sys$stat(Userspace<const Syscall::SC_stat_params*> user_params)
if (result.is_error())
return result;
if (!copy_to_user(params.statbuf, &statbuf))
return -EFAULT;
return EFAULT;
return 0;
}