RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:27:44 +00:00
Code Issues Activity Actions

LibWeb: Don't allow setting Range start/end to document being destroyed

Browse source
This commit is contained in:
Andreas Kling 2022-03-21 20:37:49 +01:00
parent 3b6323340a
commit ac8a8459d0
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/DOM/Range.cpp
View file

@ -129,6 +129,13 @@ static RelativeBoundaryPointPosition position_of_boundary_point_relative_to_othe
ExceptionOr<void> Range::set_start_or_end(Node& node, u32 offset, StartOrEnd start_or_end)
{
// FIXME: If the incoming node is part of a document that's in the process of being destroyed,
// we just ignore this. This prevents us from trying to re-ref a document during its
// destruction process. This is a hack and should be replaced with some smarter form
// of lifetime management.
if (node.document().in_removed_last_ref())
return {};
// To set the start or end of a range to a boundary point (node, offset), run these steps:
// 1. If node is a doctype, then throw an "InvalidNodeTypeError" DOMException.