RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:17:34 +00:00
Code Issues Activity Actions

FileManager: Port to GTableModel/GTableView.

Browse source 
Replace the custom DirectoryView widget with a GTableView subclass.
This was pleasantly straightforward and it's so cool seeing the huge
increase in app quality from GTableView. :^)
This commit is contained in:
Andreas Kling 2019-03-01 13:54:28 +01:00
parent b5dcad932e
commit ac8fb5da4c
8 changed files with 308 additions and 236 deletions
Download patch file Download diff file Expand all files Collapse all files

59
Applications/FileManager/DirectoryView.h
View file

@ -1,59 +0,0 @@
#pragma once
#include <LibGUI/GWidget.h>
#include <AK/Function.h>
#include <sys/stat.h>
class GScrollBar;
class DirectoryView final : public GWidget {
public:
DirectoryView(GWidget* parent);
virtual ~DirectoryView() override;
void open(const String& path);
void reload();
Function<void(const String&)> on_path_change;
Function<void(String)> on_status_message;
int item_height() const { return 16; }
int item_count() const { return m_directories.size() + m_files.size(); }
private:
virtual void paint_event(GPaintEvent&) override;
virtual void resize_event(GResizeEvent&) override;
virtual void mousedown_event(GMouseEvent&) override;
void set_status_message(String&&);
Rect row_rect(int item_index) const;
struct Entry {
String name;
size_t size { 0 };
mode_t mode { 0 };
bool is_directory() const { return S_ISDIR(mode); }
};
const Entry& entry(int index) const
{
if (index < m_directories.size())
return m_directories[index];
return m_files[index - m_directories.size()];
}
const GraphicsBitmap& icon_for(const Entry&) const;
bool should_show_size_for(const Entry&) const;
Vector<Entry> m_files;
Vector<Entry> m_directories;
String m_path;
RetainPtr<GraphicsBitmap> m_directory_icon;
RetainPtr<GraphicsBitmap> m_file_icon;
RetainPtr<GraphicsBitmap> m_symlink_icon;
RetainPtr<GraphicsBitmap> m_socket_icon;
GScrollBar* m_scrollbar { nullptr };
};