RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 17:55:08 +00:00
Code Issues Activity Actions

Kernel: Remove FIXME about unsurfaced error and log something

Browse source 
If something goes wrong when trying to write out a perfcore file during
process finalization, there's nowhere to report an error to, other than
the debug log. So write it to the debug log.
This commit is contained in:
Andreas Kling 2020-10-10 23:46:40 +02:00
parent 31791945ab
commit ac8fe3d062
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Process.cpp
View file

@ -597,9 +597,11 @@ void Process::finalize()
if (!description_or_error.is_error()) {
auto& description = description_or_error.value();
auto json = m_perf_event_buffer->to_json(m_pid, m_executable ? m_executable->absolute_path() : "");
// FIXME: Should this error path be surfaced somehow?
auto json_buffer = UserOrKernelBuffer::for_kernel_buffer(json.data());
(void)description->write(json_buffer, json.size());
auto result = description->write(json_buffer, json.size());
if (result.is_error()) {
dbgln("Error while writing perfcore file: {}", result.error().error());
}
}
}