RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:07:35 +00:00
Code Issues Activity Actions

LibWeb: Reset the HTML editing cursor blink cycle on arrow key movement

Browse source 
Also stop exposing the DOM cursor as a mutable reference on Frame,
since event handling code was using that to mess with the text offset
directly. Setting the cursor now always goes through the Frame where
we can reset the blink cycle appropriately.

This makes cursor movement look a lot more natural. :^)
This commit is contained in:
Andreas Kling 2021-02-09 21:23:50 +01:00
parent 2c4829cb14
commit ace1b34798
3 changed files with 33 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/Page/Frame.cpp
View file

@ -72,8 +72,11 @@ void Frame::setup()
void Frame::did_edit(Badge<EditEventHandler>)
{
// The user has edited the content, restart the cursor blink cycle so that
// the cursor doesn't disappear during rapid continuous editing.
reset_cursor_blink_cycle();
}
void Frame::reset_cursor_blink_cycle()
{
m_cursor_blink_state = true;
m_cursor_blink_timer->restart();
}
@ -211,7 +214,7 @@ Gfx::IntPoint Frame::to_main_frame_position(const Gfx::IntPoint& a_position)
return position;
}
void Frame::set_cursor_position(const DOM::Position& position)
void Frame::set_cursor_position(DOM::Position position)
{
if (m_cursor_position == position)
return;
@ -219,12 +222,12 @@ void Frame::set_cursor_position(const DOM::Position& position)
if (m_cursor_position.node() && m_cursor_position.node()->layout_node())
m_cursor_position.node()->layout_node()->set_needs_display();
m_cursor_position = position;
m_cursor_position = move(position);
if (m_cursor_position.node() && m_cursor_position.node()->layout_node())
m_cursor_position.node()->layout_node()->set_needs_display();
dbgln("Cursor position: {}", m_cursor_position);
reset_cursor_blink_cycle();
}
String Frame::selected_text() const