RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

AK: SinglyLinkedList use Traits<T>::equals in find

Browse source 
Use Traits<T>::equals for equality checking in search
functions instead of  operator==
This commit is contained in:
Muhammad Zahalqa 2020-09-06 22:49:36 +03:00 • committed by Andreas Kling
parent f1a6884a51
commit ad3e6ef344
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
AK/SinglyLinkedList.h
View file

@ -28,6 +28,7 @@
#include <AK/Assertions.h> #include <AK/Assertions.h>
#include <AK/StdLibExtras.h> #include <AK/StdLibExtras.h>
#include <AK/Traits.h>
#include <AK/Types.h> #include <AK/Types.h>
namespace AK { namespace AK {
@ -35,7 +36,7 @@ namespace AK {
template<typename ListType, typename ElementType> template<typename ListType, typename ElementType>
class SinglyLinkedListIterator { class SinglyLinkedListIterator {
public: public:
SinglyLinkedListIterator() {} SinglyLinkedListIterator() { }
bool operator!=(const SinglyLinkedListIterator& other) const { return m_node != other.m_node; } bool operator!=(const SinglyLinkedListIterator& other) const { return m_node != other.m_node; }
SinglyLinkedListIterator& operator++() SinglyLinkedListIterator& operator++()
{ {
@ -76,7 +77,7 @@ private:
}; };
public: public:
SinglyLinkedList() {} SinglyLinkedList() { }
~SinglyLinkedList() { clear(); } ~SinglyLinkedList() { clear(); }
bool is_empty() const { return !head(); } bool is_empty() const { return !head(); }
@ -152,11 +153,7 @@ public:
bool contains_slow(const T& value) const bool contains_slow(const T& value) const
{ {
for (auto* node = m_head; node; node = node->next) { return find(value) != end();
if (node->value == value)
return true;
}
return false;
} }
using Iterator = SinglyLinkedListIterator<SinglyLinkedList, T>; using Iterator = SinglyLinkedListIterator<SinglyLinkedList, T>;
@ -195,12 +192,12 @@ public:
ConstIterator find(const T& value) const ConstIterator find(const T& value) const
{ {
return find([&](auto& other) { return value == other; }); return find([&](auto& other) { return Traits<T>::equals(value, other); });
} }
Iterator find(const T& value) Iterator find(const T& value)
{ {
return find([&](auto& other) { return value == other; }); return find([&](auto& other) { return Traits<T>::equals(value, other); });
} }
void remove(Iterator iterator) void remove(Iterator iterator)