From ad60a0b522cede4bf95b7ea93660e9caf0e1930a Mon Sep 17 00:00:00 2001 From: Tim Schumacher Date: Wed, 12 Apr 2023 16:23:24 +0200 Subject: [PATCH] Fuzzers: Stop loading audio frames once the end is reached Previously, the condition was reversed, so we would stop immediately on a file that has at least one working chunk, and we would infinitely loop on a file with no chunks. --- Meta/Lagom/Fuzzers/FuzzFlacLoader.cpp | 2 +- Meta/Lagom/Fuzzers/FuzzMP3Loader.cpp | 2 +- Meta/Lagom/Fuzzers/FuzzQOALoader.cpp | 2 +- Meta/Lagom/Fuzzers/FuzzWAVLoader.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Meta/Lagom/Fuzzers/FuzzFlacLoader.cpp b/Meta/Lagom/Fuzzers/FuzzFlacLoader.cpp index 7c06c0e560..cdf9ad1f79 100644 --- a/Meta/Lagom/Fuzzers/FuzzFlacLoader.cpp +++ b/Meta/Lagom/Fuzzers/FuzzFlacLoader.cpp @@ -22,7 +22,7 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size) auto samples = flac->load_chunks(10 * KiB); if (samples.is_error()) return 0; - if (samples.value().size() > 0) + if (samples.value().size() == 0) break; } diff --git a/Meta/Lagom/Fuzzers/FuzzMP3Loader.cpp b/Meta/Lagom/Fuzzers/FuzzMP3Loader.cpp index d871390718..a04d1391d0 100644 --- a/Meta/Lagom/Fuzzers/FuzzMP3Loader.cpp +++ b/Meta/Lagom/Fuzzers/FuzzMP3Loader.cpp @@ -22,7 +22,7 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size) auto samples = mp3->load_chunks(1 * KiB); if (samples.is_error()) return 0; - if (samples.value().size() > 0) + if (samples.value().size() == 0) break; } diff --git a/Meta/Lagom/Fuzzers/FuzzQOALoader.cpp b/Meta/Lagom/Fuzzers/FuzzQOALoader.cpp index 52780971e9..a0c28cb5bb 100644 --- a/Meta/Lagom/Fuzzers/FuzzQOALoader.cpp +++ b/Meta/Lagom/Fuzzers/FuzzQOALoader.cpp @@ -22,7 +22,7 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size) auto samples = qoa->load_chunks(5 * KiB); if (samples.is_error()) return 0; - if (samples.value().size() > 0) + if (samples.value().size() == 0) break; } diff --git a/Meta/Lagom/Fuzzers/FuzzWAVLoader.cpp b/Meta/Lagom/Fuzzers/FuzzWAVLoader.cpp index 1cdfa40777..ce910d2690 100644 --- a/Meta/Lagom/Fuzzers/FuzzWAVLoader.cpp +++ b/Meta/Lagom/Fuzzers/FuzzWAVLoader.cpp @@ -25,7 +25,7 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size) auto samples = wav->load_chunks(4 * KiB); if (samples.is_error()) return 0; - if (samples.value().size() > 0) + if (samples.value().size() == 0) break; }