RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:47:35 +00:00
Code Issues Activity Actions

LibWeb: Make factory method of URL::URL fallible

Browse source
This commit is contained in:
Kenneth Myhra 2023-02-14 20:01:04 +01:00 • committed by Linus Groh
parent 6688f89ad3
commit ada0a59fc1
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/URL/URL.cpp
View file

@ -13,9 +13,9 @@
namespace Web::URL { namespace Web::URL {
JS::NonnullGCPtr<URL> URL::create(JS::Realm& realm, AK::URL url, JS::NonnullGCPtr<URLSearchParams> query) WebIDL::ExceptionOr<JS::NonnullGCPtr<URL>> URL::create(JS::Realm& realm, AK::URL url, JS::NonnullGCPtr<URLSearchParams> query)
{ {
return realm.heap().allocate<URL>(realm, realm, move(url), move(query)).release_allocated_value_but_fixme_should_propagate_errors(); return MUST_OR_THROW_OOM(realm.heap().allocate<URL>(realm, realm, move(url), move(query)));
} }
WebIDL::ExceptionOr<JS::NonnullGCPtr<URL>> URL::construct_impl(JS::Realm& realm, DeprecatedString const& url, DeprecatedString const& base) WebIDL::ExceptionOr<JS::NonnullGCPtr<URL>> URL::construct_impl(JS::Realm& realm, DeprecatedString const& url, DeprecatedString const& base)
@ -45,7 +45,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<URL>> URL::construct_impl(JS::Realm& realm,
// 7. Set this’s query object to a new URLSearchParams object. // 7. Set this’s query object to a new URLSearchParams object.
auto query_object = MUST(URLSearchParams::construct_impl(realm, query)); auto query_object = MUST(URLSearchParams::construct_impl(realm, query));
// 8. Initialize this’s query object with query. // 8. Initialize this’s query object with query.
auto result_url = URL::create(realm, move(parsed_url), move(query_object)); auto result_url = TRY(URL::create(realm, move(parsed_url), move(query_object)));
// 9. Set this’s query object’s URL object to this. // 9. Set this’s query object’s URL object to this.
result_url->m_query->m_url = result_url; result_url->m_query->m_url = result_url;

2
Userland/Libraries/LibWeb/URL/URL.h
View file

@ -19,7 +19,7 @@ class URL : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(URL, Bindings::PlatformObject); WEB_PLATFORM_OBJECT(URL, Bindings::PlatformObject);
public: public:
static JS::NonnullGCPtr<URL> create(JS::Realm&, AK::URL url, JS::NonnullGCPtr<URLSearchParams> query); static WebIDL::ExceptionOr<JS::NonnullGCPtr<URL>> create(JS::Realm&, AK::URL url, JS::NonnullGCPtr<URLSearchParams> query);
static WebIDL::ExceptionOr<JS::NonnullGCPtr<URL>> construct_impl(JS::Realm&, DeprecatedString const& url, DeprecatedString const& base); static WebIDL::ExceptionOr<JS::NonnullGCPtr<URL>> construct_impl(JS::Realm&, DeprecatedString const& url, DeprecatedString const& base);
virtual ~URL() override; virtual ~URL() override;