RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 13:55:08 +00:00
Code Issues Activity Actions

WebContent: Put some debug spam behind an #ifdef

Browse source
This commit is contained in:
Andreas Kling 2020-07-04 23:19:12 +02:00
parent 3005c0af69
commit ada3c9ca46
3 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Demos/WebView/WebContentClient.cpp
View file

@ -44,18 +44,24 @@ void WebContentClient::handshake()
void WebContentClient::handle(const Messages::WebContentClient::DidPaint& message) void WebContentClient::handle(const Messages::WebContentClient::DidPaint& message)
{ {
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentClient::DidPaint! content_rect=" << message.content_rect() << ", shbuf_id=" << message.shbuf_id(); dbg() << "handle: WebContentClient::DidPaint! content_rect=" << message.content_rect() << ", shbuf_id=" << message.shbuf_id();
#endif
m_view.notify_server_did_paint({}, message.shbuf_id()); m_view.notify_server_did_paint({}, message.shbuf_id());
} }
void WebContentClient::handle(const Messages::WebContentClient::DidFinishLoad& message) void WebContentClient::handle([[maybe_unused]] const Messages::WebContentClient::DidFinishLoad& message)
{ {
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentClient::DidFinishLoad! url=" << message.url(); dbg() << "handle: WebContentClient::DidFinishLoad! url=" << message.url();
#endif
} }
void WebContentClient::handle(const Messages::WebContentClient::DidInvalidateContentRect& message) void WebContentClient::handle(const Messages::WebContentClient::DidInvalidateContentRect& message)
{ {
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentClient::DidInvalidateContentRect! content_rect=" << message.content_rect(); dbg() << "handle: WebContentClient::DidInvalidateContentRect! content_rect=" << message.content_rect();
#endif
// FIXME: Figure out a way to coalesce these messages to reduce unnecessary painting // FIXME: Figure out a way to coalesce these messages to reduce unnecessary painting
m_view.notify_server_did_invalidate_content_rect({}, message.content_rect()); m_view.notify_server_did_invalidate_content_rect({}, message.content_rect());
@ -63,6 +69,8 @@ void WebContentClient::handle(const Messages::WebContentClient::DidInvalidateCon
void WebContentClient::handle(const Messages::WebContentClient::DidChangeSelection&) void WebContentClient::handle(const Messages::WebContentClient::DidChangeSelection&)
{ {
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentClient::DidChangeSelection!"; dbg() << "handle: WebContentClient::DidChangeSelection!";
#endif
m_view.notify_server_did_change_selection({}); m_view.notify_server_did_change_selection({});
} }

4
Demos/WebView/WebContentView.cpp
View file

@ -84,9 +84,11 @@ void WebContentView::notify_server_did_paint(Badge<WebContentClient>, i32 shbuf_
update(); update();
} }
void WebContentView::notify_server_did_invalidate_content_rect(Badge<WebContentClient>, const Gfx::IntRect& content_rect) void WebContentView::notify_server_did_invalidate_content_rect(Badge<WebContentClient>, [[maybe_unused]] const Gfx::IntRect& content_rect)
{ {
#ifdef DEBUG_SPAM
dbg() << "server did invalidate content_rect: " << content_rect << ", current shbuf_id=" << m_bitmap->shbuf_id(); dbg() << "server did invalidate content_rect: " << content_rect << ", current shbuf_id=" << m_bitmap->shbuf_id();
#endif
request_repaint(); request_repaint();
} }

6
Services/WebContent/ClientConnection.cpp
View file

@ -82,19 +82,25 @@ void ClientConnection::handle(const Messages::WebContentServer::UpdateSystemThem
void ClientConnection::handle(const Messages::WebContentServer::LoadURL& message) void ClientConnection::handle(const Messages::WebContentServer::LoadURL& message)
{ {
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentServer::LoadURL: url=" << message.url(); dbg() << "handle: WebContentServer::LoadURL: url=" << message.url();
#endif
page().load(message.url()); page().load(message.url());
} }
void ClientConnection::handle(const Messages::WebContentServer::SetViewportRect& message) void ClientConnection::handle(const Messages::WebContentServer::SetViewportRect& message)
{ {
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentServer::SetViewportRect: rect=" << message.rect(); dbg() << "handle: WebContentServer::SetViewportRect: rect=" << message.rect();
#endif
m_page_host->set_viewport_rect(message.rect()); m_page_host->set_viewport_rect(message.rect());
} }
void ClientConnection::handle(const Messages::WebContentServer::Paint& message) void ClientConnection::handle(const Messages::WebContentServer::Paint& message)
{ {
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentServer::Paint: content_rect=" << message.content_rect() << ", shbuf_id=" << message.shbuf_id(); dbg() << "handle: WebContentServer::Paint: content_rect=" << message.content_rect() << ", shbuf_id=" << message.shbuf_id();
#endif
auto shared_buffer = SharedBuffer::create_from_shbuf_id(message.shbuf_id()); auto shared_buffer = SharedBuffer::create_from_shbuf_id(message.shbuf_id());
if (!shared_buffer) { if (!shared_buffer) {