RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:17:35 +00:00
Code Issues Activity Actions

LibWeb: Forward CRC2D's ref count to HTMLCanvasElement

Browse source 
This allows HTMLCanvasElement and CRC2D to share their lifetime, as JS
allows them to arbitrarily access them at any time and CRC2D.canvas
expects a non-null return value.
This commit is contained in:
Luke Wilde 2022-06-19 19:42:27 +01:00 • committed by Linus Groh
parent cd9864bbf1
commit adf8341c4e
3 changed files with 29 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.h
View file

@ -7,7 +7,7 @@
#pragma once
#include <AK/RefCounted.h>
#include <AK/RefCountForwarder.h>
#include <AK/Variant.h>
#include <LibGfx/AffineTransform.h>
#include <LibGfx/Color.h>
@ -27,7 +27,7 @@ namespace Web::HTML {
using CanvasImageSource = Variant<NonnullRefPtr<HTMLImageElement>, NonnullRefPtr<HTMLCanvasElement>>;
class CanvasRenderingContext2D
: public RefCounted<CanvasRenderingContext2D>
: public RefCountForwarder<HTMLCanvasElement>
, public Bindings::Wrappable {
AK_MAKE_NONCOPYABLE(CanvasRenderingContext2D);
@ -90,7 +90,7 @@ public:
void reset_to_default_state();
HTMLCanvasElement* canvas() { return m_element; }
NonnullRefPtr<HTMLCanvasElement> canvas_for_binding() const;
RefPtr<TextMetrics> measure_text(String const& text);
@ -122,7 +122,8 @@ private:
OwnPtr<Gfx::Painter> painter();
WeakPtr<HTMLCanvasElement> m_element;
HTMLCanvasElement& canvas_element();
HTMLCanvasElement const& canvas_element() const;
// https://html.spec.whatwg.org/multipage/canvas.html#drawing-state
struct DrawingState {