RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 09:02:43 +00:00
Code Issues Activity Actions

LibWeb: Always inline absolute Length to_px() conversion

Browse source 
Only do the relative Length units out of line.
This commit is contained in:
Andreas Kling 2020-06-23 23:21:58 +02:00
parent 5f0a1ef21b
commit ae181e1573
2 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/CSS/Length.cpp
View file

@ -30,13 +30,9 @@
namespace Web { namespace Web {
float Length::to_px(const LayoutNode& layout_node) const float Length::relative_length_to_px(const LayoutNode& layout_node) const
{ {
switch (m_type) { switch (m_type) {
case Type::Auto:
return 0;
case Type::Px:
return m_value;
case Type::Em: case Type::Em:
return m_value * layout_node.font_size(); return m_value * layout_node.font_size();
case Type::Rem: case Type::Rem:

16
Libraries/LibWeb/CSS/Length.h
View file

@ -57,7 +57,19 @@ public:
bool is_relative() const { return m_type == Type::Em || m_type == Type::Rem; } bool is_relative() const { return m_type == Type::Em || m_type == Type::Rem; }
float raw_value() const { return m_value; } float raw_value() const { return m_value; }
float to_px(const LayoutNode&) const; ALWAYS_INLINE float to_px(const LayoutNode& layout_node) const
{
if (is_relative())
return relative_length_to_px(layout_node);
switch (m_type) {
case Type::Auto:
return 0;
case Type::Px:
return m_value;
default:
ASSERT_NOT_REACHED();
}
}
String to_string() const String to_string() const
{ {
@ -67,6 +79,8 @@ public:
} }
private: private:
float relative_length_to_px(const LayoutNode&) const;
const char* unit_name() const; const char* unit_name() const;
Type m_type { Type::Auto }; Type m_type { Type::Auto };