RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 06:02:44 +00:00
Code Issues Activity Actions

LibWeb: Improve HTMLImageElement::{width,height}()

Browse source 
With this change, it will correctly return the width/height when the
image element has an assigned width/height attribute.
This commit is contained in:
Igor Pissolati 2022-04-12 13:28:52 -03:00 • committed by Andreas Kling
parent e5d978af9f
commit ae519c6fef
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -101,6 +101,11 @@ unsigned HTMLImageElement::width() const
if (auto* paint_box = this->paint_box())
return paint_box->content_width();
// NOTE: This step seems to not be in the spec, but all browsers do it.
auto width_attr = get_attribute(HTML::AttributeNames::width);
if (auto converted = width_attr.to_uint(); converted.has_value())
return *converted;
// ...or else the density-corrected intrinsic width and height of the image, in CSS pixels,
// if the image has intrinsic dimensions and is available but not being rendered.
if (m_image_loader.has_image())
@ -124,6 +129,11 @@ unsigned HTMLImageElement::height() const
if (auto* paint_box = this->paint_box())
return paint_box->content_height();
// NOTE: This step seems to not be in the spec, but all browsers do it.
auto height_attr = get_attribute(HTML::AttributeNames::height);
if (auto converted = height_attr.to_uint(); converted.has_value())
return *converted;
// ...or else the density-corrected intrinsic height and height of the image, in CSS pixels,
// if the image has intrinsic dimensions and is available but not being rendered.
if (m_image_loader.has_image())