From ae66188d43ab67e13159925dd34a71e4881c3059 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sun, 24 Oct 2021 08:44:29 -0400 Subject: [PATCH] LibUnicode: Capitialize generated identifiers in lieu of full title case This isn't particularly important because this generates code that is quite hidden from outside callers. But when viewing the generated code, it's a bit nicer to read e.g. enum identifiers such as "MinusSign" rather than "Minussign". --- .../Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp index bb8df81141..252c393e0d 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeLocale.cpp @@ -601,7 +601,9 @@ static String format_identifier(StringView owner, String identifier) if (all_of(identifier, is_ascii_digit)) return String::formatted("{}_{}", owner[0], identifier); - return identifier.to_titlecase(); + if (is_ascii_lower_alpha(identifier[0])) + return String::formatted("{:c}{}", to_ascii_uppercase(identifier[0]), identifier.substring_view(1)); + return identifier; } static void generate_unicode_locale_header(Core::File& file, UnicodeLocaleData& locale_data)