RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:27:35 +00:00
Code Issues Activity Actions

LibJS: Implement Array.prototype.toSpliced()

Browse source
This commit is contained in:
Linus Groh 2022-06-13 08:00:29 +01:00
parent ce17c868c0
commit ae81793f20
5 changed files with 239 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Tests/builtins/Array/Array.prototype-generic-functions.js
View file

@ -354,4 +354,10 @@ describe("ability to work with generic non-array objects", () => {
expect(result).toEqual(["bar", "baz", "foo", undefined, undefined]);
expect(result).not.toBe(o);
});
test("toSpliced", () => {
const result = Array.prototype.toSpliced.call(o, 1, 2, "hello", "friends");
expect(result).toEqual(["foo", "hello", "friends", "baz", undefined]);
expect(result).not.toBe(o);
});
});

100
Userland/Libraries/LibJS/Tests/builtins/Array/Array.prototype.toSpliced.js Normal file
View file

@ -0,0 +1,100 @@
describe("normal behavior", () => {
test("length is 2", () => {
expect(Array.prototype.toSpliced).toHaveLength(2);
});
test("no start or delete count argument", () => {
const a = [1, 2, 3, 4, 5];
const b = a.toSpliced();
expect(a).not.toBe(b);
expect(a).toEqual([1, 2, 3, 4, 5]);
expect(b).toEqual([1, 2, 3, 4, 5]);
});
test("only start argument", () => {
const a = [1, 2, 3, 4, 5];
const values = [
[0, []],
[1, [1]],
[4, [1, 2, 3, 4]],
[-1, [1, 2, 3, 4]],
[999, [1, 2, 3, 4, 5]],
[Infinity, [1, 2, 3, 4, 5]],
];
for (const [start, expected] of values) {
const b = a.toSpliced(start);
expect(a).not.toBe(b);
expect(a).toEqual([1, 2, 3, 4, 5]);
expect(b).toEqual(expected);
}
});
test("start and delete count argument", () => {
const a = [1, 2, 3, 4, 5];
const values = [
[0, 5, []],
[1, 3, [1, 5]],
[4, 1, [1, 2, 3, 4]],
[-1, 1, [1, 2, 3, 4]],
[999, 10, [1, 2, 3, 4, 5]],
[Infinity, Infinity, [1, 2, 3, 4, 5]],
];
for (const [start, deleteCount, expected] of values) {
const b = a.toSpliced(start, deleteCount);
expect(a).not.toBe(b);
expect(a).toEqual([1, 2, 3, 4, 5]);
expect(b).toEqual(expected);
}
});
test("start, delete count, and items argument", () => {
const a = [1, 2, 3, 4, 5];
const values = [
[0, 5, ["foo", "bar"], ["foo", "bar"]],
[1, 3, ["foo", "bar"], [1, "foo", "bar", 5]],
[4, 1, ["foo", "bar"], [1, 2, 3, 4, "foo", "bar"]],
[-1, 1, ["foo", "bar"], [1, 2, 3, 4, "foo", "bar"]],
[999, 10, ["foo", "bar"], [1, 2, 3, 4, 5, "foo", "bar"]],
[Infinity, Infinity, ["foo", "bar"], [1, 2, 3, 4, 5, "foo", "bar"]],
];
for (const [start, deleteCount, items, expected] of values) {
const b = a.toSpliced(start, deleteCount, ...items);
expect(a).not.toBe(b);
expect(a).toEqual([1, 2, 3, 4, 5]);
expect(b).toEqual(expected);
}
});
test("is unscopable", () => {
expect(Array.prototype[Symbol.unscopables].toSpliced).toBeTrue();
const array = [];
with (array) {
expect(() => {
toSpliced;
}).toThrowWithMessage(ReferenceError, "'toSpliced' is not defined");
}
});
});
describe("errors", () => {
test("null or undefined this value", () => {
expect(() => {
Array.prototype.toSpliced.call();
}).toThrowWithMessage(TypeError, "ToObject on null or undefined");
expect(() => {
Array.prototype.toSpliced.call(undefined);
}).toThrowWithMessage(TypeError, "ToObject on null or undefined");
expect(() => {
Array.prototype.toSpliced.call(null);
}).toThrowWithMessage(TypeError, "ToObject on null or undefined");
});
test("maximum array size exceeded", () => {
const a = { length: 2 ** 53 - 1 };
expect(() => {
Array.prototype.toSpliced.call(a, 0, 0, "foo");
}).toThrowWithMessage(TypeError, "Maximum array size exceeded");
});
});