RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:07:44 +00:00
Code Issues Activity Actions

LibWeb: Treat SVG fill/stroke/stroke-width attributes as CSS properties

Browse source 
Rather than having separate systems for the attributes and their CSS
equivalents, we can treat the attributes as presentational hints and
convert them to CSS properties. This means they can be inherited, as
they should. :^)

As noted, the `fill` and `stroke` attributes do not fully match the
`fill` and `stroke` properties. The CSS spec is still an early draft and
not entirely helpful, so we can just pretend they are the same for now.
This commit is contained in:
Sam Atkins 2022-01-24 15:43:44 +00:00 • committed by Andreas Kling
parent f4ceea2a0e
commit ae99cbe534
2 changed files with 20 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/SVG/SVGGraphicsElement.h
View file

@ -1,6 +1,6 @@
/*
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
* Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -20,16 +20,11 @@ public:
SVGGraphicsElement(DOM::Document&, QualifiedName);
virtual void parse_attribute(FlyString const& name, String const& value) override;
virtual void apply_presentational_hints(CSS::StyleProperties&) const override;
Optional<Gfx::Color> fill_color() const;
Optional<Gfx::Color> stroke_color() const;
Optional<float> stroke_width() const;
protected:
Optional<Gfx::Color> m_fill_color;
Optional<Gfx::Color> m_stroke_color;
Optional<float> m_stroke_width;
};
}