mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 15:57:45 +00:00
Kernel: Introduce the DeviceManagement singleton
This singleton simplifies many aspects that we struggled with before: 1. There's no need to make derived classes of Device expose the constructor as public anymore. The singleton is a friend of them, so he can call the constructor. This solves the issue with try_create_device helper neatly, hopefully for good. 2. Getting a reference of the NullDevice is now being done from this singleton, which means that NullDevice no longer needs to use its own singleton, and we can apply the try_create_device helper on it too :) 3. We can now defer registration completely after the Device constructor which means the Device constructor is merely assigning the major and minor numbers of the Device, and the try_create_device helper ensures it calls the after_inserting method immediately after construction. This creates a great opportunity to make registration more OOM-safe.
This commit is contained in:
parent
9aa6dd6b78
commit
aee4786d8e
43 changed files with 244 additions and 123 deletions
88
Kernel/Devices/DeviceManagement.cpp
Normal file
88
Kernel/Devices/DeviceManagement.cpp
Normal file
|
@ -0,0 +1,88 @@
|
|||
/*
|
||||
* Copyright (c) 2021, Liav A. <liavalb@hotmail.co.il>
|
||||
*
|
||||
* SPDX-License-Identifier: BSD-2-Clause
|
||||
*/
|
||||
|
||||
#include <AK/HashTable.h>
|
||||
#include <AK/Singleton.h>
|
||||
#include <Kernel/Devices/DeviceManagement.h>
|
||||
#include <Kernel/FileSystem/InodeMetadata.h>
|
||||
#include <Kernel/Sections.h>
|
||||
|
||||
namespace Kernel {
|
||||
|
||||
static Singleton<DeviceManagement> s_the;
|
||||
|
||||
UNMAP_AFTER_INIT DeviceManagement::DeviceManagement()
|
||||
{
|
||||
}
|
||||
UNMAP_AFTER_INIT void DeviceManagement::initialize()
|
||||
{
|
||||
s_the.ensure_instance();
|
||||
}
|
||||
|
||||
UNMAP_AFTER_INIT void DeviceManagement::attach_null_device(NullDevice const& device)
|
||||
{
|
||||
m_null_device = device;
|
||||
}
|
||||
|
||||
DeviceManagement& DeviceManagement::the()
|
||||
{
|
||||
return *s_the;
|
||||
}
|
||||
|
||||
Device* DeviceManagement::get_device(unsigned major, unsigned minor)
|
||||
{
|
||||
return m_devices.with_exclusive([&](auto& map) -> Device* {
|
||||
auto it = map.find(encoded_device(major, minor));
|
||||
if (it == map.end())
|
||||
return nullptr;
|
||||
return it->value;
|
||||
});
|
||||
}
|
||||
|
||||
void DeviceManagement::before_device_removal(Badge<Device>, Device& device)
|
||||
{
|
||||
u32 device_id = encoded_device(device.major(), device.minor());
|
||||
m_devices.with_exclusive([&](auto& map) -> void {
|
||||
VERIFY(map.contains(device_id));
|
||||
map.remove(encoded_device(device.major(), device.minor()));
|
||||
});
|
||||
}
|
||||
|
||||
void DeviceManagement::after_inserting_device(Badge<Device>, Device& device)
|
||||
{
|
||||
u32 device_id = encoded_device(device.major(), device.minor());
|
||||
m_devices.with_exclusive([&](auto& map) -> void {
|
||||
if (map.contains(device_id)) {
|
||||
dbgln("Already registered {},{}: {}", device.major(), device.minor(), device.class_name());
|
||||
VERIFY_NOT_REACHED();
|
||||
}
|
||||
auto result = map.set(device_id, &device);
|
||||
if (result != AK::HashSetResult::InsertedNewEntry) {
|
||||
dbgln("Failed to register {},{}: {}", device.major(), device.minor(), device.class_name());
|
||||
VERIFY_NOT_REACHED();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
void DeviceManagement::for_each(Function<void(Device&)> callback)
|
||||
{
|
||||
m_devices.with_exclusive([&](auto& map) -> void {
|
||||
for (auto& entry : map)
|
||||
callback(*entry.value);
|
||||
});
|
||||
}
|
||||
|
||||
NullDevice& DeviceManagement::null_device()
|
||||
{
|
||||
return *m_null_device;
|
||||
}
|
||||
|
||||
NullDevice const& DeviceManagement::null_device() const
|
||||
{
|
||||
return *m_null_device;
|
||||
}
|
||||
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue