mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 23:37:36 +00:00
Kernel: Introduce the DeviceManagement singleton
This singleton simplifies many aspects that we struggled with before: 1. There's no need to make derived classes of Device expose the constructor as public anymore. The singleton is a friend of them, so he can call the constructor. This solves the issue with try_create_device helper neatly, hopefully for good. 2. Getting a reference of the NullDevice is now being done from this singleton, which means that NullDevice no longer needs to use its own singleton, and we can apply the try_create_device helper on it too :) 3. We can now defer registration completely after the Device constructor which means the Device constructor is merely assigning the major and minor numbers of the Device, and the try_create_device helper ensures it calls the after_inserting method immediately after construction. This creates a great opportunity to make registration more OOM-safe.
This commit is contained in:
parent
9aa6dd6b78
commit
aee4786d8e
43 changed files with 244 additions and 123 deletions
|
@ -21,6 +21,8 @@ namespace Kernel {
|
|||
class PS2KeyboardDevice final : public IRQHandler
|
||||
, public KeyboardDevice
|
||||
, public I8042Device {
|
||||
friend class DeviceManagement;
|
||||
|
||||
public:
|
||||
static RefPtr<PS2KeyboardDevice> try_to_initialize(const I8042Controller&);
|
||||
virtual ~PS2KeyboardDevice() override;
|
||||
|
@ -35,10 +37,9 @@ public:
|
|||
enable_irq();
|
||||
}
|
||||
|
||||
// FIXME: We expose this constructor to make try_create_device helper to work
|
||||
private:
|
||||
explicit PS2KeyboardDevice(const I8042Controller&);
|
||||
|
||||
private:
|
||||
// ^IRQHandler
|
||||
virtual bool handle_irq(const RegisterState&) override;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue