RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-29 10:37:34 +00:00
Code Issues Activity Actions

AK+LibWeb: Round to int in clamp_to_int instead of truncating

Browse source 
This caused inaccuracies in float->CssPixel conversions
This commit is contained in:
Hendiadyoin1 2023-07-29 15:30:57 +02:00 • committed by Alexander Kalenik
parent 7b7ba38655
commit af161a8b83
58 changed files with 693 additions and 692 deletions
Download patch file Download diff file Expand all files Collapse all files

130
Tests/LibWeb/Layout/expected/acid1.txt
View file

@ -1,15 +1,15 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x419.921875 [BFC] children: not-inline
BlockContainer <html> at (0,0) content-size 800x420 [BFC] children: not-inline
BlockContainer <(anonymous)> at (0,0) content-size 800x0 children: inline
TextNode <#text>
BlockContainer <body> at (20,20) content-size 480x379.921875 children: not-inline
BlockContainer <body> at (20,20) content-size 480x380 children: not-inline
BlockContainer <(anonymous)> at (20,20) content-size 480x0 children: inline
TextNode <#text>
BlockContainer <dl> at (25,25) content-size 470x0 children: inline
TextNode <#text>
BlockContainer <dt> at (40,40) content-size 49.984375x280 floating [BFC] children: inline
line 0 width: 28.296875, height: 10, bottom: 10, baseline: 7.984375
frag 0 from TextNode start: 0, length: 6, rect: [40,40 28.296875x10]
BlockContainer <dt> at (40,40) content-size 50x280 floating [BFC] children: inline
line 0 width: 28.3125, height: 10, bottom: 10, baseline: 8
frag 0 from TextNode start: 0, length: 6, rect: [40,40 28.3125x10]
"toggle"
TextNode <#text>
TextNode <#text>
@ -19,55 +19,55 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <ul> at (135,45) content-size 340x0 children: inline
TextNode <#text>
BlockContainer <li> at (150,60) content-size 50x90 floating [BFC] children: inline
line 0 width: 37.875, height: 10, bottom: 10, baseline: 7.984375
line 0 width: 37.875, height: 10, bottom: 10, baseline: 8
frag 0 from TextNode start: 0, length: 7, rect: [150,60 37.875x10]
"the way"
TextNode <#text>
TextNode <#text>
BlockContainer <li#bar> at (235,55) content-size 139.96875x90 floating [BFC] children: not-inline
BlockContainer <(anonymous)> at (235,55) content-size 139.96875x0 children: inline
BlockContainer <li#bar> at (235,55) content-size 139.984375x90 floating [BFC] children: not-inline
BlockContainer <(anonymous)> at (235,55) content-size 139.984375x0 children: inline
TextNode <#text>
BlockContainer <p> at (235,55) content-size 139.96875x10 children: inline
line 0 width: 74.3125, height: 10, bottom: 10, baseline: 7.984375
BlockContainer <p> at (235,55) content-size 139.984375x10 children: inline
line 0 width: 74.3125, height: 10, bottom: 10, baseline: 8
frag 0 from TextNode start: 0, length: 14, rect: [235,55 74.3125x10]
"the world ends"
TextNode <#text>
BlockContainer <(anonymous)> at (235,65) content-size 139.96875x0 children: inline
BlockContainer <(anonymous)> at (235,65) content-size 139.984375x0 children: inline
TextNode <#text>
InlineNode <form>
TextNode <#text>
TextNode <#text>
TextNode <#text>
BlockContainer <p> at (235,65) content-size 139.96875x18.984375 children: inline
line 0 width: 39.484375, height: 18.984375, bottom: 18.984375, baseline: 12.46875
frag 0 from TextNode start: 1, length: 5, rect: [235,65 27.484375x18.984375]
BlockContainer <p> at (235,65) content-size 139.984375x19 children: inline
line 0 width: 39.484375, height: 19, bottom: 19, baseline: 12.5
frag 0 from TextNode start: 1, length: 5, rect: [235,65 27.484375x19]
"bang "
frag 1 from RadioButton start: 0, length: 0, rect: [262.484375,65.46875 12x12]
frag 1 from RadioButton start: 0, length: 0, rect: [262.484375,65.5 12x12]
TextNode <#text>
RadioButton <input> at (262.484375,65.46875) content-size 12x12 inline-block children: not-inline
RadioButton <input> at (262.484375,65.5) content-size 12x12 inline-block children: not-inline
TextNode <#text>
BlockContainer <p> at (235,83.984375) content-size 139.96875x18.984375 children: inline
line 0 width: 57.15625, height: 18.984375, bottom: 18.984375, baseline: 12.46875
frag 0 from TextNode start: 1, length: 8, rect: [235,83.984375 45.15625x18.984375]
BlockContainer <p> at (235,84) content-size 139.984375x19 children: inline
line 0 width: 57.15625, height: 19, bottom: 19, baseline: 12.5
frag 0 from TextNode start: 1, length: 8, rect: [235,84 45.15625x19]
"whimper "
frag 1 from RadioButton start: 0, length: 0, rect: [280.15625,84.453125 12x12]
frag 1 from RadioButton start: 0, length: 0, rect: [280.15625,84.5 12x12]
TextNode <#text>
RadioButton <input> at (280.15625,84.453125) content-size 12x12 inline-block children: not-inline
RadioButton <input> at (280.15625,84.5) content-size 12x12 inline-block children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> at (235,102.96875) content-size 139.96875x0 children: inline
BlockContainer <(anonymous)> at (235,103) content-size 139.984375x0 children: inline
TextNode <#text>
TextNode <#text>
BlockContainer <li> at (409.96875,60) content-size 50x90 floating [BFC] children: inline
line 0 width: 31.5625, height: 10, bottom: 10, baseline: 7.984375
frag 0 from TextNode start: 0, length: 6, rect: [409.96875,60 31.5625x10]
BlockContainer <li> at (409.984375,60) content-size 50x90 floating [BFC] children: inline
line 0 width: 31.578125, height: 10, bottom: 10, baseline: 8
frag 0 from TextNode start: 0, length: 6, rect: [409.984375,60 31.578125x10]
"i grow"
line 1 width: 14.03125, height: 10, bottom: 20, baseline: 7.984375
frag 0 from TextNode start: 7, length: 3, rect: [409.96875,70 14.03125x10]
line 1 width: 14.03125, height: 10, bottom: 20, baseline: 8
frag 0 from TextNode start: 7, length: 3, rect: [409.984375,70 14.03125x10]
"old"
TextNode <#text>
TextNode <#text>
BlockContainer <li#baz> at (145,185) content-size 100x100 floating [BFC] children: inline
line 0 width: 29.421875, height: 10, bottom: 10, baseline: 7.984375
line 0 width: 29.421875, height: 10, bottom: 10, baseline: 8
frag 0 from TextNode start: 0, length: 6, rect: [145,185 29.421875x10]
"pluot?"
TextNode <#text>
@ -78,10 +78,10 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <(anonymous)> at (280,195) content-size 50x0 children: inline
TextNode <#text>
BlockContainer <address> at (280,195) content-size 50x20 children: inline
line 0 width: 17.265625, height: 10, bottom: 10, baseline: 7.984375
frag 0 from TextNode start: 0, length: 3, rect: [280,195 17.265625x10]
line 0 width: 17.28125, height: 10, bottom: 10, baseline: 8
frag 0 from TextNode start: 0, length: 3, rect: [280,195 17.28125x10]
"bar"
line 1 width: 30.21875, height: 10, bottom: 20, baseline: 7.984375
line 1 width: 30.21875, height: 10, bottom: 20, baseline: 8
frag 0 from TextNode start: 4, length: 6, rect: [280,205 30.21875x10]
"maids,"
TextNode <#text>
@ -89,10 +89,10 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
TextNode <#text>
BlockContainer <h1> at (365,185) content-size 100x100 floating [BFC] children: inline
line 0 width: 56.390625, height: 10, bottom: 10, baseline: 7.984375
frag 0 from TextNode start: 0, length: 11, rect: [365,185 56.390625x10]
line 0 width: 56.421875, height: 10, bottom: 10, baseline: 8
frag 0 from TextNode start: 0, length: 11, rect: [365,185 56.421875x10]
"sing to me,"
line 1 width: 65.4375, height: 10, bottom: 20, baseline: 7.984375
line 1 width: 65.4375, height: 10, bottom: 20, baseline: 8
frag 0 from TextNode start: 12, length: 12, rect: [365,195 65.4375x10]
"erbarme dich"
TextNode <#text>
@ -100,29 +100,29 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> at (20,30) content-size 480x0 children: inline
TextNode <#text>
BlockContainer <p> at (20,335) content-size 480x64.921875 children: inline
line 0 width: 473.5625, height: 12.984375, bottom: 12.984375, baseline: 9.46875
frag 0 from TextNode start: 1, length: 90, rect: [20,335 473.5625x12.984375]
BlockContainer <p> at (20,335) content-size 480x65 children: inline
line 0 width: 473.625, height: 13, bottom: 13, baseline: 9.5
frag 0 from TextNode start: 1, length: 90, rect: [20,335 473.625x13]
"This is a nonsensical document, but syntactically valid HTML 4.0. All 100%-conformant CSS1"
line 1 width: 396.859375, height: 12.984375, bottom: 25.96875, baseline: 9.46875
frag 0 from TextNode start: 92, length: 74, rect: [20,347.984375 396.859375x12.984375]
line 1 width: 396.96875, height: 13, bottom: 26, baseline: 9.5
frag 0 from TextNode start: 92, length: 74, rect: [20,348 396.96875x13]
"agents should be able to render the document elements above this paragraph"
line 2 width: 470.5, height: 12.984375, bottom: 38.953125, baseline: 9.46875
frag 0 from TextNode start: 167, length: 43, rect: [20,360.96875 207.875x12.984375]
line 2 width: 470.578125, height: 13, bottom: 39, baseline: 9.5
frag 0 from TextNode start: 167, length: 43, rect: [20,361 207.890625x13]
"indistinguishably (to the pixel) from this "
frag 1 from TextNode start: 0, length: 20, rect: [227.875,360.96875 102.984375x12.984375]
frag 1 from TextNode start: 0, length: 20, rect: [227.890625,361 103.015625x13]
"reference rendering,"
frag 2 from TextNode start: 0, length: 31, rect: [330.859375,360.96875 159.640625x12.984375]
frag 2 from TextNode start: 0, length: 31, rect: [330.90625,361 159.671875x13]
" (except font rasterization and"
line 3 width: 464.9375, height: 12.984375, bottom: 51.9375, baseline: 9.46875
frag 0 from TextNode start: 32, length: 89, rect: [20,373.953125 464.9375x12.984375]
line 3 width: 465.015625, height: 13, bottom: 52, baseline: 9.5
frag 0 from TextNode start: 32, length: 89, rect: [20,374 465.015625x13]
"form widgets). All discrepancies should be traceable to CSS1 implementation shortcomings."
line 4 width: 408.046875, height: 12.984375, bottom: 64.921875, baseline: 9.46875
frag 0 from TextNode start: 122, length: 67, rect: [20,386.9375 345.46875x12.984375]
line 4 width: 408.15625, height: 13, bottom: 65, baseline: 9.5
frag 0 from TextNode start: 122, length: 67, rect: [20,387 345.546875x13]
"Once you have finished evaluating this test, you can return to the "
frag 1 from TextNode start: 0, length: 11, rect: [365.46875,386.9375 59.875x12.984375]
frag 1 from TextNode start: 0, length: 11, rect: [365.546875,387 59.890625x13]
"parent page"
frag 2 from TextNode start: 0, length: 1, rect: [425.34375,386.9375 2.703125x12.984375]
frag 2 from TextNode start: 0, length: 1, rect: [425.4375,387 2.71875x13]
"."
TextNode <#text>
InlineNode <a>
@ -131,36 +131,36 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
InlineNode <a>
TextNode <#text>
TextNode <#text>
BlockContainer <(anonymous)> at (20,399.921875) content-size 480x0 children: inline
BlockContainer <(anonymous)> at (20,400) content-size 480x0 children: inline
TextNode <#text>
PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x419.921875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x420]
PaintableWithLines (BlockContainer(anonymous)) [0,0 800x0]
PaintableWithLines (BlockContainer<BODY>) [15,15 490x389.921875]
PaintableWithLines (BlockContainer<BODY>) [15,15 490x390]
PaintableWithLines (BlockContainer(anonymous)) [20,20 480x0]
PaintableWithLines (BlockContainer<DL>) [20,20 480x10]
PaintableWithLines (BlockContainer<DT>) [25,25 79.984375x310]
PaintableWithLines (BlockContainer<DT>) [25,25 80x310]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DD>) [115,25 380x310]
PaintableWithLines (BlockContainer(anonymous)) [135,45 340x0]
PaintableWithLines (BlockContainer<UL>) [135,45 340x0]
PaintableWithLines (BlockContainer<LI>) [135,45 80x120]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<LI>#bar) [225,45 159.96875x110]
PaintableWithLines (BlockContainer(anonymous)) [235,55 139.96875x0]
PaintableWithLines (BlockContainer<P>) [235,55 139.96875x10]
PaintableWithLines (BlockContainer<LI>#bar) [225,45 159.984375x110]
PaintableWithLines (BlockContainer(anonymous)) [235,55 139.984375x0]
PaintableWithLines (BlockContainer<P>) [235,55 139.984375x10]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [235,65 139.96875x0]
PaintableWithLines (BlockContainer(anonymous)) [235,65 139.984375x0]
InlinePaintable (InlineNode<FORM>)
PaintableWithLines (BlockContainer<P>) [235,65 139.96875x18.984375]
PaintableWithLines (BlockContainer<P>) [235,65 139.984375x19]
TextPaintable (TextNode<#text>)
RadioButtonPaintable (RadioButton<INPUT>) [262.484375,65.46875 12x12]
PaintableWithLines (BlockContainer<P>) [235,83.984375 139.96875x18.984375]
RadioButtonPaintable (RadioButton<INPUT>) [262.484375,65.5 12x12]
PaintableWithLines (BlockContainer<P>) [235,84 139.984375x19]
TextPaintable (TextNode<#text>)
RadioButtonPaintable (RadioButton<INPUT>) [280.15625,84.453125 12x12]
PaintableWithLines (BlockContainer(anonymous)) [235,102.96875 139.96875x0]
PaintableWithLines (BlockContainer<LI>) [394.96875,45 80x120]
RadioButtonPaintable (RadioButton<INPUT>) [280.15625,84.5 12x12]
PaintableWithLines (BlockContainer(anonymous)) [235,103 139.984375x0]
PaintableWithLines (BlockContainer<LI>) [394.984375,45 80x120]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<LI>#baz) [135,175 120x120]
TextPaintable (TextNode<#text>)
@ -173,7 +173,7 @@ PaintableWithLines (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<H1>) [355,175 120x120]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [20,30 480x0]
PaintableWithLines (BlockContainer<P>) [20,335 480x64.921875]
PaintableWithLines (BlockContainer<P>) [20,335 480x65]
TextPaintable (TextNode<#text>)
InlinePaintable (InlineNode<A>)
TextPaintable (TextNode<#text>)
@ -181,4 +181,4 @@ PaintableWithLines (Viewport<#document>) [0,0 800x600]
InlinePaintable (InlineNode<A>)
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [20,399.921875 480x0]
PaintableWithLines (BlockContainer(anonymous)) [20,400 480x0]