RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:57:44 +00:00
Code Issues Activity Actions

Kernel: Use try_create not must_create in SysFSUSB::create

Browse source 
The function `KString::must_create()` can only be enforced
during early boot (that is, when `g_in_early_boot` is true), hence
the use of this function during runtime causes a `VERIFY` to assert,
leading to a Kernel Panic.
We should instead use `TRY()` along with `try_create()` to prevent
this from crashing whenever a USB device is inserted into the system,
and we don't have enough memory to allocate the device's KString.
This commit is contained in:
Jesse Buhagiar 2022-01-03 00:48:46 +11:00 • committed by Idan Horowitz
parent 1d7d7d39b7
commit af31253a16
2 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Bus/USB/SysFSUSB.h
View file

@ -19,7 +19,7 @@ class SysFSUSBDeviceInformation : public SysFSComponent {
public:
virtual ~SysFSUSBDeviceInformation() override;
static NonnullRefPtr<SysFSUSBDeviceInformation> create(USB::Device&);
static ErrorOr<NonnullRefPtr<SysFSUSBDeviceInformation>> create(USB::Device&);
virtual StringView name() const override { return m_device_name->view(); }
RefPtr<USB::Device> device() const { return m_device; }