RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 03:08:13 +00:00
Code Issues Activity Actions

Ladybird: Fix compilation on macOS/Clang

Browse source 
- Silences the -Wuser-defined-literals warning which is triggered by our
  use of the `sv` suffix for StringView
- Removes an unused captured `this` pointer [-Wunused-lambda-capture]
- Changes a JSONArray.h include to JSONObject.h to get the definition
  for `JSONValue::serialize`. This is needed because template functions
  are not exported for dylibs on macOS. This is a hack; the JSON headers
  should be refactored so that each one includes the definition of
  the template functions it sees. -- Maybe we should build with
  -fvisibility-inlines-hidden on Linux to catch issues like this?
This commit is contained in:
Daniel Bertalan 2022-07-13 21:33:22 +02:00 • committed by Andrew Kaster
parent d1d6a204fc
commit af5250b2cb
3 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Ladybird/RequestManagerQt.cpp
View file

@ -5,7 +5,7 @@
*/
#include "RequestManagerQt.h"
#include <AK/JsonArray.h>
#include <AK/JsonObject.h>
RequestManagerQt::RequestManagerQt()
{