RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:07:35 +00:00
Code Issues Activity Actions

LibJS: Don't assume call_frame->current_node in Exception constructor

Browse source 
It's a nullptr in promise reaction job functions, for example. Regressed
in 97d49cb.

Fixes #6641.
This commit is contained in:
Linus Groh 2021-04-25 21:45:23 +02:00
parent dbe72fd962
commit af62678c31
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Exception.cpp
View file

@ -24,7 +24,11 @@ Exception::Exception(Value value)
function_name = "<anonymous>";
m_traceback.prepend({
.function_name = move(function_name),
.source_range = call_frame->current_node->source_range(),
// We might not have an AST node associated with the call frame, e.g. in promise
// reaction jobs (which aren't called anywhere from the source code).
// They're not going to generate any _unhandled_ exceptions though, so a meaningless
// source range is fine.
.source_range = call_frame->current_node ? call_frame->current_node->source_range() : SourceRange {},
});
}
}