1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:58:11 +00:00

Kernel: Negate condition in ARPTableBlockerSet::should_add_blocker

To prevent a race condition in case we received the ARP response in the
window between creating and initializing the Thread Blocker and the
actual blocking, we were checking if the IP address was updated in the
ARP table just before starting to block.
Unfortunately, the condition was partially flipped, which meant that if
the table was updated with the IP address we would still end up
blocking, at which point we would never end unblocking again, which
would result in LookupServer locking up as well.
This commit is contained in:
Idan Horowitz 2022-07-03 23:23:45 +03:00
parent 4947804121
commit af71aa4e0b

View file

@ -76,7 +76,7 @@ protected:
});
if (!maybe_mac_address.has_value())
return true;
return blocker.unblock_if_matching_ip_address(true, blocker.ip_address(), maybe_mac_address.value());
return !blocker.unblock_if_matching_ip_address(true, blocker.ip_address(), maybe_mac_address.value());
}
};