RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-22 22:37:40 +00:00
Code Issues Activity Actions

CNetworkJob: Automatically delete finished jobs after on_finish.

Browse source 
Also, pretty-print any failure messages.
This commit is contained in:
Andreas Kling 2019-06-22 22:46:05 +02:00
parent 639478391b
commit af75ccee65
2 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
LibCore/CNetworkJob.cpp
View file

@ -16,12 +16,28 @@ void CNetworkJob::did_finish(NonnullRefPtr<CNetworkResponse>&& response)
printf("%s{%p} job did_finish!\n", class_name(), this);
ASSERT(on_finish);
on_finish(true);
delete_later();
}
void CNetworkJob::did_fail(Error error)
{
m_error = error;
dbgprintf("%s{%p} job did_fail! error=%u\n", class_name(), this, (unsigned)error);
dbgprintf("%s{%p} job did_fail! error: %u (%s)\n", class_name(), this, (unsigned)error, to_string(error));
ASSERT(on_finish);
on_finish(false);
delete_later();
}
const char* to_string(CNetworkJob::Error error)
{
switch (error) {
case CNetworkJob::Error::ProtocolFailed:
return "ProtocolFailed";
case CNetworkJob::Error::ConnectionFailed:
return "ConnectionFailed";
case CNetworkJob::Error::TransmissionFailed:
return "TransmissionFailed";
default:
return "(Unknown error)";
}
}