From af8cd477b4c34a1962ee7a0504dd9b833d5de257 Mon Sep 17 00:00:00 2001 From: thankyouverycool <66646555+thankyouverycool@users.noreply.github.com> Date: Sun, 7 May 2023 08:22:29 -0400 Subject: [PATCH] LibGUI: Always paint vertical lines for Frames in unmaximized windows Fixes incorrect thread highlighting for ResourceGraph panels. Prior to FrameStyles, these graphs were painted as faux-panels, this is, sunken containers with a thickness of 1, and weren't subject to the bug. --- Userland/Libraries/LibGUI/Frame.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibGUI/Frame.cpp b/Userland/Libraries/LibGUI/Frame.cpp index 2ecaff705d..b171dc1074 100644 --- a/Userland/Libraries/LibGUI/Frame.cpp +++ b/Userland/Libraries/LibGUI/Frame.cpp @@ -7,6 +7,7 @@ #include #include +#include #include #include @@ -60,7 +61,8 @@ void Frame::paint_event(PaintEvent& event) Painter painter(*this); painter.add_clip_rect(event.rect()); - Gfx::StylePainter::paint_frame(painter, rect(), palette(), m_style, spans_entire_window_horizontally()); + bool skip_vertical_lines = window()->is_maximized() && spans_entire_window_horizontally(); + Gfx::StylePainter::paint_frame(painter, rect(), palette(), m_style, skip_vertical_lines); } Gfx::IntRect Frame::children_clip_rect() const