RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

Toolchain: Use set -o pipefail to the toolchain build script

Browse source 
Previously the buildstep function would obscure error codes because
the return value of the function was the exit code for the sed command
which caused us to continue execution even though one of the build
steps had failed.

With set -o pipefail the return value of the buildstep function is
the real command's exit code.
This commit is contained in:
Gunnar Beutner 2021-05-27 08:02:57 +02:00 • committed by Linus Groh
parent 3ea256b1c6
commit afbab621aa
1 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Toolchain/BuildIt.sh
View file

@ -1,5 +1,5 @@
#!/usr/bin/env bash #!/usr/bin/env bash
set -e set -eo pipefail
# This file will need to be run in bash, for now. # This file will need to be run in bash, for now.
@ -137,18 +137,24 @@ popd
# === DOWNLOAD AND PATCH === # === DOWNLOAD AND PATCH ===
pushd "$DIR/Tarballs" pushd "$DIR/Tarballs"
md5="$($MD5SUM $BINUTILS_PKG | cut -f1 -d' ')" md5=""
echo "bu md5='$md5'" if [ -e "$BINUTILS_PKG" ]; then
if [ ! -e $BINUTILS_PKG ] || [ "$md5" != ${BINUTILS_MD5SUM} ] ; then md5="$($MD5SUM $BINUTILS_PKG | cut -f1 -d' ')"
echo "bu md5='$md5'"
fi
if [ "$md5" != ${BINUTILS_MD5SUM} ] ; then
rm -f $BINUTILS_PKG rm -f $BINUTILS_PKG
curl -LO "$BINUTILS_BASE_URL/$BINUTILS_PKG" curl -LO "$BINUTILS_BASE_URL/$BINUTILS_PKG"
else else
echo "Skipped downloading binutils" echo "Skipped downloading binutils"
fi fi
md5="$($MD5SUM ${GCC_PKG} | cut -f1 -d' ')" md5=""
echo "gc md5='$md5'" if [ -e "$GCC_PKG" ]; then
if [ ! -e $GCC_PKG ] || [ "$md5" != ${GCC_MD5SUM} ] ; then md5="$($MD5SUM ${GCC_PKG} | cut -f1 -d' ')"
echo "gc md5='$md5'"
fi
if [ "$md5" != ${GCC_MD5SUM} ] ; then
rm -f $GCC_PKG rm -f $GCC_PKG
curl -LO "$GCC_BASE_URL/$GCC_NAME/$GCC_PKG" curl -LO "$GCC_BASE_URL/$GCC_NAME/$GCC_PKG"
else else