RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:47:34 +00:00
Code Issues Activity Actions

LibWeb: Remove ValueListStyleValue :^)

Browse source 
This was the whole point of this PR. No more dealing with
ComponentValues in StyleResolver!
This commit is contained in:
Sam Atkins 2021-08-12 12:11:59 +01:00 • committed by Andreas Kling
parent 678760bd87
commit afc434c416
4 changed files with 2 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibWeb/CSS/StyleValue.h
View file

@ -227,7 +227,6 @@ public:
CustomProperty,
Numeric,
ValueList,
ComponentValueList,
Calculated,
Background,
BackgroundRepeat,
@ -254,7 +253,6 @@ public:
bool is_custom_property() const { return type() == Type::CustomProperty; }
bool is_numeric() const { return type() == Type::Numeric; }
bool is_value_list() const { return type() == Type::ValueList; }
bool is_component_value_list() const { return type() == Type::ComponentValueList; }
bool is_calculated() const { return type() == Type::Calculated; }
bool is_background() const { return type() == Type::Background; }
bool is_background_repeat() const { return type() == Type::BackgroundRepeat; }
@ -1020,21 +1018,6 @@ private:
NonnullRefPtrVector<StyleValue> m_values;
};
class ValueListStyleValue final : public StyleValue {
public:
static NonnullRefPtr<ValueListStyleValue> create(Vector<StyleComponentValueRule>&& values) { return adopt_ref(*new ValueListStyleValue(move(values))); }
virtual ~ValueListStyleValue() override { }
virtual String to_string() const override;
Vector<StyleComponentValueRule> const& values() const { return m_values; }
private:
ValueListStyleValue(Vector<StyleComponentValueRule>&&);
Vector<StyleComponentValueRule> m_values;
};
inline CSS::ValueID StyleValue::to_identifier() const
{
if (is_identifier())