From afeee35cbf5466d4df15f5481c23315c41a677b3 Mon Sep 17 00:00:00 2001 From: Gunnar Beutner Date: Mon, 26 Apr 2021 23:06:58 +0200 Subject: [PATCH] Kernel: Avoid calling characters() where not necessary --- Kernel/PerformanceEventBuffer.cpp | 4 ++-- Kernel/Syscalls/mmap.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Kernel/PerformanceEventBuffer.cpp b/Kernel/PerformanceEventBuffer.cpp index d1960e600a..f7c7983e43 100644 --- a/Kernel/PerformanceEventBuffer.cpp +++ b/Kernel/PerformanceEventBuffer.cpp @@ -221,7 +221,7 @@ void PerformanceEventBuffer::add_process(const Process& process, ProcessEventTyp [[maybe_unused]] auto rc = append_with_eip_and_ebp(process.pid(), 0, 0, 0, event_type == ProcessEventType::Create ? PERF_EVENT_PROCESS_CREATE : PERF_EVENT_PROCESS_EXEC, - process.pid().value(), 0, executable.characters()); + process.pid().value(), 0, executable); process.for_each_thread([&](auto& thread) { [[maybe_unused]] auto rc = append_with_eip_and_ebp(process.pid(), thread.tid().value(), @@ -231,7 +231,7 @@ void PerformanceEventBuffer::add_process(const Process& process, ProcessEventTyp for (auto& region : process.space().regions()) { [[maybe_unused]] auto rc = append_with_eip_and_ebp(process.pid(), 0, - 0, 0, PERF_EVENT_MMAP, region->range().base().get(), region->range().size(), region->name().characters()); + 0, 0, PERF_EVENT_MMAP, region->range().base().get(), region->range().size(), region->name()); } } diff --git a/Kernel/Syscalls/mmap.cpp b/Kernel/Syscalls/mmap.cpp index 2ceae850ad..07d2b66247 100644 --- a/Kernel/Syscalls/mmap.cpp +++ b/Kernel/Syscalls/mmap.cpp @@ -249,7 +249,7 @@ KResultOr Process::sys$mmap(Userspace u if (auto* event_buffer = current_perf_events_buffer()) { [[maybe_unused]] auto res = event_buffer->append(PERF_EVENT_MMAP, region->vaddr().get(), - region->size(), name.is_null() ? region->name().characters() : name.characters()); + region->size(), name.is_null() ? region->name() : name); } region->set_mmap(true);