RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:27:35 +00:00
Code Issues Activity Actions

LibJS+js: Disable console debug messages outside Serenity only for js

Browse source 
Previously we would disable console debug messages on all non Serenity
platforms as it caused double printing on lagom `js`. This patch limits
this to the `js` utility, allowing LibWeb to print debug messages
regardless of the operating system :^)
This commit is contained in:
networkException 2022-10-15 22:38:31 +02:00 • committed by Ali Mohammad Pur
parent 5e26bb7643
commit afeff4cebb
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Console.cpp
View file

@ -427,9 +427,8 @@ MarkedVector<Value> Console::vm_arguments()
return arguments;
}
void Console::output_debug_message([[maybe_unused]] LogLevel log_level, [[maybe_unused]] String output) const
void Console::output_debug_message(LogLevel log_level, String const& output) const
{
#ifdef AK_OS_SERENITY
switch (log_level) {
case Console::LogLevel::Debug:
dbgln("\033[32;1m(js debug)\033[0m {}", output);
@ -450,7 +449,6 @@ void Console::output_debug_message([[maybe_unused]] LogLevel log_level, [[maybe_
dbgln("\033[32;1m(js)\033[0m {}", output);
break;
}
#endif
}
void Console::report_exception(JS::Error const& exception, bool in_promise) const

2
Userland/Libraries/LibJS/Console.h
View file

@ -81,7 +81,7 @@ public:
ThrowCompletionOr<Value> time_log();
ThrowCompletionOr<Value> time_end();
void output_debug_message(LogLevel log_level, String output) const;
void output_debug_message(LogLevel log_level, String const& output) const;
void report_exception(JS::Error const&, bool) const;
private:

2
Userland/Utilities/js.cpp
View file

@ -1472,7 +1472,9 @@ public:
}
auto output = String::join(' ', arguments.get<JS::MarkedVector<JS::Value>>());
#ifdef AK_OS_SERENITY
m_console.output_debug_message(log_level, output);
#endif
switch (log_level) {
case JS::Console::LogLevel::Debug: