RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

LibGfx: Verify ICC reserved header bytes are zero

Browse source 
I checked that they are zero for all profiles in Compact-ICC-Profiles
and for all .icc files in /Library/ColorSync and
/System/Library/ColorSync on my Mac (running macOS 12.6.2).
This commit is contained in:
Nico Weber 2023-01-06 12:06:12 -05:00 • committed by Linus Groh
parent 090bd02a88
commit b0068c387b
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibGfx/ICCProfile.cpp
View file

@ -259,6 +259,15 @@ Optional<Crypto::Hash::MD5::DigestType> parse_profile_id(ICCHeader const& header
return md5; return md5;
} }
ErrorOr<void> parse_reserved(ICCHeader const& header)
{
// ICC v4, 7.2.19 Reserved field
// "This field of the profile header is reserved for future ICC definition and shall be set to zero."
if (!all_bytes_are_zero(header.reserved))
return Error::from_string_literal("ICC::Profile: Reserved header bytes are not zero");
return {};
}
} }
StringView device_class_name(DeviceClass device_class) StringView device_class_name(DeviceClass device_class)
@ -391,6 +400,7 @@ ErrorOr<NonnullRefPtr<Profile>> Profile::try_load_from_externally_owned_memory(R
profile->m_rendering_intent = TRY(parse_rendering_intent(header)); profile->m_rendering_intent = TRY(parse_rendering_intent(header));
profile->m_pcs_illuminant = TRY(parse_pcs_illuminant(header)); profile->m_pcs_illuminant = TRY(parse_pcs_illuminant(header));
profile->m_id = parse_profile_id(header); profile->m_id = parse_profile_id(header);
TRY(parse_reserved(header));
return profile; return profile;
} }