RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:47:45 +00:00
Code Issues Activity Actions

Everywhere: Forward declare structs as structs

Browse source 
While structs being forward declared as classes is not strictly an
issue, Clang complains as this is not portable code, since some ABIs
treat classes declared as `class` and `struct` differently.

It's easier to fix these than to reason about explicitly disabling
another warning.
This commit is contained in:
Daniel Bertalan 2021-07-05 19:12:37 +02:00 • committed by Gunnar Beutner
parent e32692ea68
commit b0208ce433
5 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/Profiler/TimelineHeader.h
View file

@ -11,7 +11,7 @@
namespace Profiler { namespace Profiler {
class Profile; class Profile;
class Process; struct Process;
class TimelineHeader final : public GUI::Frame { class TimelineHeader final : public GUI::Frame {
C_OBJECT(TimelineHeader); C_OBJECT(TimelineHeader);

2
Userland/DevTools/Profiler/TimelineTrack.h
View file

@ -11,7 +11,7 @@
namespace Profiler { namespace Profiler {
class Process; struct Process;
class Profile; class Profile;
class TimelineView; class TimelineView;

2
Userland/Libraries/LibIPC/Stub.h
View file

@ -16,7 +16,7 @@ class BufferStream;
namespace IPC { namespace IPC {
class Message; class Message;
class MessageBuffer; struct MessageBuffer;
class Stub { class Stub {
public: public:

2
Userland/Libraries/LibWeb/Forward.h
View file

@ -60,7 +60,7 @@ namespace Web::HTML {
class CanvasRenderingContext2D; class CanvasRenderingContext2D;
class CloseEvent; class CloseEvent;
class DOMParser; class DOMParser;
class EventHandler; struct EventHandler;
class HTMLAnchorElement; class HTMLAnchorElement;
class HTMLAreaElement; class HTMLAreaElement;
class HTMLAudioElement; class HTMLAudioElement;

2
Userland/Services/WindowServer/Compositor.h
View file

@ -212,7 +212,7 @@ private:
return iterate_flush_rects(m_flush_transparent_rects); return iterate_flush_rects(m_flush_transparent_rects);
} }
}; };
friend class ScreenData; friend struct ScreenData;
Vector<ScreenData, default_screen_count> m_screen_data; Vector<ScreenData, default_screen_count> m_screen_data;
IntrusiveList<Overlay, RawPtr<Overlay>, &Overlay::m_list_node> m_overlay_list; IntrusiveList<Overlay, RawPtr<Overlay>, &Overlay::m_list_node> m_overlay_list;