RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:57:35 +00:00
Code Issues Activity Actions

LibWeb: Fix null dereference in ResourceClient::set_resource()

Browse source 
If resource_did_load() results in the ResourceClient being destroyed,
we can't dereference the weak ResourceClient right after.
This commit is contained in:
Andreas Kling 2022-09-21 10:36:29 +02:00
parent 68d0f30368
commit b02402e116
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/Loader/Resource.cpp
View file

@ -176,12 +176,16 @@ void ResourceClient::set_resource(Resource* resource)
return; return;
// Make sure that reused resources also have their load callback fired. // Make sure that reused resources also have their load callback fired.
if (weak_this->m_resource->is_loaded()) if (weak_this->m_resource->is_loaded()) {
weak_this->resource_did_load(); weak_this->resource_did_load();
return;
}
// Make sure that reused resources also have their fail callback fired. // Make sure that reused resources also have their fail callback fired.
if (weak_this->m_resource->is_failed()) if (weak_this->m_resource->is_failed()) {
weak_this->resource_did_fail(); weak_this->resource_did_fail();
return;
}
}); });
} }
} }