RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 09:02:43 +00:00
Code Issues Activity Actions

LibJS: Allow null or undefined as a bound |this| value in strict mode

Browse source
This commit is contained in:
Jack Karamanian 2020-06-02 21:26:35 -05:00 • committed by Andreas Kling
parent 870bcaeef6
commit b0932b0aec
2 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/Function.cpp
View file

@ -57,7 +57,8 @@ BoundFunction* Function::bind(Value bound_this_value, Vector<Value> arguments)
switch (bound_this_value.type()) { switch (bound_this_value.type()) {
case Value::Type::Undefined: case Value::Type::Undefined:
case Value::Type::Null: case Value::Type::Null:
// FIXME: Null or undefined should be passed through in strict mode. if (interpreter().in_strict_mode())
return bound_this_value;
return &interpreter().global_object(); return &interpreter().global_object();
default: default:
return bound_this_value.to_object(interpreter()); return bound_this_value.to_object(interpreter());

18
Libraries/LibJS/Tests/Function.prototype.bind.js
View file

@ -103,15 +103,17 @@ try {
assert(Make5() === 5); assert(Make5() === 5);
assert(new Make5().valueOf() === 5); assert(new Make5().valueOf() === 5);
// FIXME: Uncomment me when strict mode is implemented // Null or undefined should be passed through as a |this| value in strict mode.
// function strictIdentity() { (() => {
// return this; "use strict";
// } function strictIdentity() {
return this;
}
// assert(strictIdentity.bind()() === undefined); assert(strictIdentity.bind()() === undefined);
// assert(strictIdentity.bind(null)() === null); assert(strictIdentity.bind(null)() === null);
// assert(strictIdentity.bind(undefined)() === undefined); assert(strictIdentity.bind(undefined)() === undefined);
// })(); })();
// Arrow functions can not have their |this| value set. // Arrow functions can not have their |this| value set.
assert((() => this).bind("foo")() === globalThis) assert((() => this).bind("foo")() === globalThis)